Re: [KDE Usability] Review Request 128283: Add checksums tab to the properties dialog

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128283/
-----------------------------------------------------------

(Updated June 25, 2016, 2:52 p.m.)


Review request for KDE Frameworks, KDE Usability and David Faure.


Changes
-------

Preview of the new layout (code not yet implemented).

1. The "Verify" line edit becomes either green or red. Green if the pasted string is a valid checksum and matches the checksum that we compute in the background (according to the length of the input). Red otherwise. Maybe we could add a message panel on top to explain the warning/error?
2. In the "Share" groupbox, if the user clicks a "Calculate" button, the button is replaced by a "Calculating" label which later will show the resulting checksum.


Repository: kio


Description
-------

This patch adds a Checksums tab in the properties dialog, where the user can retrieve and verify the most popular checksum algorithms (md5, sha1 and sha256). 

To simplify the implementation, the checksums are computed as soon as the user opens the dialog. This can take a while if the file is huge (in particular with sha256), but the computation happens in another thread and in practice this should not be a performance problem.

The tab is available only for readable local files (no simlinks) and only when there is a single selection.

Please note that some of the labels in the screenshots are clipped due to a bug in breeze: https://bugs.kde.org/show_bug.cgi?id=364426


Diffs
-----

  src/widgets/CMakeLists.txt f9065777a0d2f1d126dc482d66e1bbb1ba127895 
  src/widgets/checksumswidget.ui PRE-CREATION 
  src/widgets/kpropertiesdialog.cpp d0a2faa5114e391680925e10646ce7c6f2ea29da 
  src/widgets/kpropertiesdialog_p.h c01554e694ff3c905e768048ce94800739760fb7 

Diff: https://git.reviewboard.kde.org/r/128283/diff/


Testing
-------

* Check whether the computed values match the values from md5sum, sha1sum, sha256sum.
* Check whether the line edits get a green background if the computed and expected values match.
* Check whether the line edits get a red background if the computed and expected values differ.


File Attachments (updated)
----------------

sha256-computing
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/25/327218af-c026-458e-a48d-512787abad42__Spectacle.st2415.png
md5-match
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/25/4b37d28e-02b9-42e2-96f2-184ffd42b31a__Spectacle.kh2415.png
sha1-differ
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/25/99fdcf92-f784-4a7d-8aba-c25b8be08c04__Spectacle.Xz2415.png
Preview of new layout
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/25/ca6efcf4-2b6c-4189-ab05-4e12277f53e2__Spectacle.ZK4766.png


Thanks,

Elvis Angelaccio

_______________________________________________
kde-usability mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-usability