Re: Review Request 128283: Add checksums tab to the properties dialog

readAll() is problematic, why to potentially fill all the ram completely,
thus removing cache?
Such approaches can degrade overall plasma's performance.

Posted from a phone.

On Sunday, 26 June 2016, Elvis Angelaccio <[email protected]>
wrote:
> This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128283/
> Review request for KDE Frameworks, KDE Usability and David Faure.
> By Elvis Angelaccio.
>
> Updated June 26, 2016, 10:34 a.m.
>
> Changes
>
> Implementation of the new layout. Checksums are cached to avoid
duplicated computations.
>
> Repository: kio
>
> Description
>
> This patch adds a Checksums tab in the properties dialog, where the user
can retrieve and verify the most popular checksum algorithms (md5, sha1 and
sha256).
>
> To simplify the implementation, the checksums are computed as soon as the
user opens the dialog. This can take a while if the file is huge (in
particular with sha256), but the computation happens in another thread and
in practice this should not be a performance problem.
>
> The tab is available only for readable local files (no simlinks) and only
when there is a single selection.
>
> Please note that some of the labels in the screenshots are clipped due to
a bug in breeze: https://bugs.kde.org/show_bug.cgi?id=364426
>
> Testing
>
> Check whether the computed values match the values from md5sum, sha1sum,
sha256sum.
> Check whether the line edits get a green background if the computed and
expected values match.
> Check whether the line edits get a red background if the computed and
expected values differ.
>
> Diffs (updated)
>
> src/widgets/CMakeLists.txt (f906577)
> src/widgets/checksumswidget.ui (PRE-CREATION)
> src/widgets/kpropertiesdialog.cpp (d0a2faa)
> src/widgets/kpropertiesdialog_p.h (c01554e)
>
> View Diff
>
> File Attachments (updated)
>
> Default dialog
> Expected checksum is ok
> Expected checksum doesn't match
> MD5 ready to be shared

-- 
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek

_______________________________________________
Kde-frameworks-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel