Re: Review Request 128283: Add checksums tab to the properties dialog

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128283/#review96871
-----------------------------------------------------------



When the verify operation is executed, shouldn't the computed checksum be (immediately) shown in the corresponding text box?

- Luigi Toscano


On Giu. 26, 2016, 2:03 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128283/
> -----------------------------------------------------------
> 
> (Updated Giu. 26, 2016, 2:03 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This patch adds a Checksums tab in the properties dialog, where the user can retrieve and verify the most popular checksum algorithms (md5, sha1 and sha256). 
> 
> To simplify the implementation, the checksums are computed as soon as the user opens the dialog. This can take a while if the file is huge (in particular with sha256), but the computation happens in another thread and in practice this should not be a performance problem.
> 
> The tab is available only for readable local files (no simlinks) and only when there is a single selection.
> 
> Please note that some of the labels in the screenshots are clipped due to a bug in breeze: https://bugs.kde.org/show_bug.cgi?id=364426
> 
> 
> Diffs
> -----
> 
>   src/widgets/CMakeLists.txt f906577 
>   src/widgets/checksumswidget.ui PRE-CREATION 
>   src/widgets/kpropertiesdialog.cpp d0a2faa 
>   src/widgets/kpropertiesdialog_p.h c01554e 
> 
> Diff: https://git.reviewboard.kde.org/r/128283/diff/
> 
> 
> Testing
> -------
> 
> * Check whether the computed values match the values from md5sum, sha1sum, sha256sum.
> * Check whether the line edits get a green background if the computed and expected values match.
> * Check whether the line edits get a red background if the computed and expected values differ.
> 
> 
> File Attachments
> ----------------
> 
> Default dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/26/a776ab78-a61a-47d5-b6e5-9e983310ffb9__Spectacle.M10844.png
> Expected checksum is ok
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/26/83ce62cf-5264-45f5-a3ff-8aa24dfadc20__Spectacle.B10844.png
> Expected checksum doesn't match
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/26/b1363353-c493-4ff6-8320-72d2eeb07c6e__Spectacle.J10844.png
> MD5 ready to be shared
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/26/b882fad9-85b0-4250-9743-3549339e6718__Spectacle.l10844.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel