[KDE Usability] Review Request 128331: [Plasma-nm] Provide better notification icons

Kai Uwe Broulik <[email protected]>
Newsgroups gmane.comp.kde.usability,gmane.comp.kde.devel.plasma,gmane.comp.kde.knetworkmanager
Message-ID <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128331/
-----------------------------------------------------------

Review request for Network Management, Plasma and KDE Usability.


Repository: plasma-nm


Description
-------

This improves the most common case by showing dedicated icons for when connecting/disconnecting wireless and wired connections instead of showing the generic warning/information icon.

Also change from notification pixmap to iconName.


Diffs
-----

  kded/notification.cpp e3d19ad 

Diff: https://git.reviewboard.kde.org/r/128331/diff/


Testing
-------

Connected and disconnected my wifi


File Attachments
----------------

Connected
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/b800147b-0e0e-4cad-87c2-6045fbe6ab65__Screenshot_20160630_221435.png
Disconnected
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/0cb34ebd-9d92-45d0-9c15-e439b1270287__Screenshot_20160630_221424.png


Thanks,

Kai Uwe Broulik

_______________________________________________
kde-usability mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-usability
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.