Re: [KDE Usability] Review Request 128331: [Plasma-nm] Provide better notification icons
yahoo-pier_andreit <[email protected]>
| Newsgroups | gmane.comp.kde.usability |
|---|---|
| Message-ID | <[email protected]> |
On 01/07/16 08:32, Jan Grulich wrote: > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128331/ > > > Ship it! > > Looks good. Thanks > It may be better something like a red cross over the red wifi wave in the case of disconnect case. manythanks, ciao, pier :-) > > - Jan Grulich > > > On červen 30th, 2016, 8:17 odp. UTC, Kai Uwe Broulik wrote: > > Review request for Network Management, Plasma and KDE Usability. > By Kai Uwe Broulik. > > /Updated Čer. 30, 2016, 8:17 odp./ > > *Repository: * plasma-nm > > > Description > > This improves the most common case by showing dedicated icons for when > connecting/disconnecting wireless and wired connections instead of > showing the generic warning/information icon. > > > Also change from notification pixmap to iconName. > > > Testing > > Connected and disconnected my wifi > > > Diffs > > * kded/notification.cpp (e3d19ad) > > View Diff <https://git.reviewboard.kde.org/r/128331/diff/> > > > File Attachments > > # Connected > <https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/b800147b-0e0e-4cad-87c2-6045fbe6ab65__Screenshot_20160630_221435.png> > # Disconnected > <https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/0cb34ebd-9d92-45d0-9c15-e439b1270287__Screenshot_20160630_221424.png> > > > > _______________________________________________ > kde-usability mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/kde-usability > _______________________________________________ kde-usability mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-usability