Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128490/#review97665
-----------------------------------------------------------



+1
It may still scare people, but I think it's a good compromise.

- Thomas Pfeiffer


On July 20, 2016, 1:01 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128490/
> -----------------------------------------------------------
> 
> (Updated July 20, 2016, 1:01 p.m.)
> 
> 
> Review request for KDE Frameworks and KDE Usability.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Follow up of RR [128283](https://git.reviewboard.kde.org/r/128283/) and in particular [128466](https://git.reviewboard.kde.org/r/128466/). This patch replaces the "Share" groupbox with a vertical separator.
> 
> Don't forget that there is also RR [128413](https://git.reviewboard.kde.org/r/128413/) pending ;)
> 
> 
> Diffs
> -----
> 
>   src/widgets/checksumswidget.ui 03c64db 
>   src/widgets/kpropertiesdialog.cpp 808765c 
> 
> Diff: https://git.reviewboard.kde.org/r/128490/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/e39d8b29-5837-4236-833b-26ecafe18bfb__checksums-tab.png
> After
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/d1ec9cee-03e5-4b26-9852-876e48aa5143__Spectacle.T11454.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel