Re: Review Request 128413: Add clipboard buttons in the Checksums tab

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128413/#review97788
-----------------------------------------------------------



If there are no objections by today, I'm going to ship this.

- Elvis Angelaccio


On July 22, 2016, 9:21 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128413/
> -----------------------------------------------------------
> 
> (Updated July 22, 2016, 9:21 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> As discussed in RR 128283, we can improve the usability of the dialog if we add buttons to interact with the clipboard.
> 
> The Paste button is always visible, while the three Copy buttons are hidden until the correspoding checksum is computed.
> 
> 
> Diffs
> -----
> 
>   src/widgets/checksumswidget.ui 543088e 
>   src/widgets/kpropertiesdialog.cpp f6d835e 
> 
> Diff: https://git.reviewboard.kde.org/r/128413/diff/
> 
> 
> Testing
> -------
> 
> Copy/Paste works as expected.
> 
> 
> File Attachments
> ----------------
> 
> Paste button next to the input field.
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/07/22/0b0d3f06-7294-4ff1-b59d-d13c413c00f5__Spectacle.C31997.png
> Example of Copy button
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/07/22/5f137d47-4592-4f4c-be96-4c2fc3d09978__Spectacle.J32017.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel