Re: Review Request 128680: [KCharSelect] Add ToolButton for disabling characters not available in selected font

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128680/#review98855
-----------------------------------------------------------



Andreas, any idea which icon the action could use?

- Christoph Feck


On Sept. 1, 2016, 4:45 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128680/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2016, 4:45 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Andreas Kainz.
> 
> 
> Bugs: 97420
>     https://bugs.kde.org/show_bug.cgi?id=97420
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Adds a toolbutton to the right of the font combobox to control the "font merging" property of QFont. When selected, characters which are not available in the font are disabled.
> 
> Seeking feedback about:
> - placement of the button
> - used icon (currently "format-text-strikethrough"; it shows an S character which could stand for "substitution")
> - action name and tooltip (see line 477 and 479)
> - and code changes ;)
> 
> I was unsure if the toolbutton could have a popup menu showing three options:
> 1) show characters from all fonts
> 2) disable characters not available in font
> 3) hide characters not available in font
> 
> but I did not implement it, because it felt odd not being able to see _which_ characters are not available in the font.
> 
> 
> Diffs
> -----
> 
>   src/kcharselect.cpp 30ddd34 
>   src/kcharselect_p.h db0259c 
> 
> Diff: https://git.reviewboard.kde.org/r/128680/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Character table with font substitution (default)
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/7220dddb-ca1b-42a2-966c-791925156baf__snapshot1.png
> Character table with dimming substituted characters
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/67c02866-b12c-4080-b6a4-22e29006448b__snapshot2.png
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>