Re: Review Request 128715: Bug 205157 - two clicks on file to rename

> On Sept. 4, 2016, 12:18 p.m., Emmanuel Pescosta wrote:
> > Thanks for the patch!
> > 
> > I don't think that we should add another option for this, because it makes the settings dialog
> > more complex, it increases the number of possible configs to test, it only makes sense when
> > single click + inline renaming is enabled.
> > 
> > What if we always enable it when the options 'single click' and 'inline renaming' are enabled?
> > 
> > Please add the usability group to this discussion :)

Usability team agrees :)
No additional option, activate it automatically when single-click and inline-renaming are activated


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128715/#review98869
-----------------------------------------------------------


On Sept. 4, 2016, 1:07 p.m., Andreas Krutzler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128715/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2016, 1:07 p.m.)
> 
> 
> Review request for Dolphin and KDE Usability.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Bug 205157 - two clicks on file to rename
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kitemlistcontroller.h b8a93edacbaeaccf382971dc17d299bcda8c6dc8 
>   src/kitemviews/kitemlistcontroller.cpp 1c86ff03ff9b0b12bb0d2927f8e4ed1e0b67b38d 
>   src/kitemviews/kitemlistview.h 9adf9f86f099a65a0a27e19271b60f49cbea4961 
>   src/kitemviews/kitemlistview.cpp df65399299ba30d48af59678d6b75f8bbb124478 
>   src/settings/dolphin_generalsettings.kcfg 12f158541187bd8d8e1359c589c1c99be6ae07a8 
>   src/settings/general/behaviorsettingspage.h 6213734f1e5146856639aa78c0268c793735403c 
>   src/settings/general/behaviorsettingspage.cpp 86a4ad3bbcabd03e19bd1237f0bb95324da3c1d7 
>   src/views/dolphinview.h d1a5d5005f81bfc07dcb62bfc38b3d0ac06a5f11 
>   src/views/dolphinview.cpp a737dd0a632cf9b27a660aac53889b5dd299057f 
> 
> Diff: https://git.reviewboard.kde.org/r/128715/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Krutzler
> 
>