Re: Review Request 128392: [kickoff] kickoff should use icons from icon theme

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128392/#review99349
-----------------------------------------------------------



Any news on that?

- Marco Martin


On July 11, 2016, 10:51 a.m., Andrey Bondrov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128392/
> -----------------------------------------------------------
> 
> (Updated July 11, 2016, 10:51 a.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Bugs: 365204
>     https://bugs.kde.org/show_bug.cgi?id=365204
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Likely kickoff should use icons from icon theme, not from plasma theme. 
> 
> https://bugs.kde.org/show_bug.cgi?id=365204
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
> 
> Diff: https://git.reviewboard.kde.org/r/128392/diff/
> 
> 
> Testing
> -------
> 
> 1. Added kickoff applet to desktop
> 2. Swicthed from Breeze LAF to Oxygen
> 3. Rebooted
> 4. Kickoff got mixed Breeze and Oxygen icons (see screenshot in #365204)
> 5. Applied the patch
> 6. Rebooted
> 7. All Kickoff icons are properly set to Oxygen
> 
> 
> Thanks,
> 
> Andrey Bondrov
> 
>