Re: Review Request 128078: Parley: Remember practice direction for each practice mode

> On Okt. 13, 2016, 4:25 nachm., Hartmut Riesenbeck wrote:
> > Does someone may have time to review?
> > 
> > I use this patch now since more than four month and find it very usefull for my way of practicing vocabulary. I don't want to miss it. May someone agree with me.
> 
> Albert Astals Cid wrote:
>     Not lots of people developing parley lately it seems, anyhow i had a look at the patch and looks sensible from my "I know nothing about this" point of view.
>     
>     If noone disagrees I'll commit it on 4 November, if something breaks you'll have to fix it ;)

Many thanks for your review, Albert.
For not to bother you with this, I could do the commit. If no objections, I'll take your suggestion and commit on 4. November.

Besides there is another bugfix in the pipeline (https://git.reviewboard.kde.org/r/128901/). May I proceed it the same way?


- Hartmut


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128078/#review99982
-----------------------------------------------------------


On Juni 6, 2016, 7:47 nachm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128078/
> -----------------------------------------------------------
> 
> (Updated Juni 6, 2016, 7:47 nachm.)
> 
> 
> Review request for KDE Edu and KDE Usability.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> New check box in StatistcsMainWindow is added. If check box is
> switched on the practice direction for the current practice mode is
> saved and will be restored when this practice mode is selected again.
> 
> This is a feature I personally missed. May it is usefull for the public.
> 
> Screenshot 1:
> I am not shure if the location for the check box, which is switching 
> the feature on and off, is well choosen here in the main window (see 
> screenshot01). Or if it's better placed in the practice configure dialog.
> 
> Screenshot 2:
> As a reply of Julians comment, I tried to improve the check box text. 
> I hope it is better understandable now (please excuse my limited english 
> knowledge). This version is ok for minimal changes on the user interface.
> But for me it is not realy satisfyingly.
> 
> Screenshot 3:
> Added frame arount the practise direction group. After this the check 
> box text can be reduce a little more. Because it's obvious that the 
> direction widgets belongs together. But for me the frame is not very 
> harmonic to the rest.
> 
> Screenshot 4:
> Grouped all practice controlling widgets into frames. This is a really 
> big change in the user interface.But it's my favorite.
> 
> I redesigned the user interface of the statistics window from the
> perspective of a programmer. This may not confirm with good user 
> interface design. So I added the usability group to the rewiers.
> I would really appreciate any comments or suggestions for improvements.
> 
> While working on this feature a smal bug was found in configuration 
> file saving. File was only saved when document was modified on 
> closing the application. Fixed it.
> 
> Sorry for the long text.  ;-)
> 
> 
> Diffs
> -----
> 
>   src/parleydocument.cpp 2f5d3b32ba4462d6b9c917b109e0787cede59513 
>   src/parleymainwindow.cpp 9fd1b92e88ed2614f4f71579ed0f2a31fca027c3 
>   src/settings/parley.kcfg 7eac0d27a6d2f5dcb94d1ed5802b7c05b0ce4eb4 
>   src/statistics/statisticsmainwindow.h f6c87231010f672c0e32aae34345785d16484d75 
>   src/statistics/statisticsmainwindow.cpp 64c7ad64057e74da5ca81b098c0e865610900bb5 
>   src/statistics/statisticsmainwindow.ui 190017cc3ca788248aa468cc90349dde873fa80d 
> 
> Diff: https://git.reviewboard.kde.org/r/128078/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> screenshot01
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/01/0d19592c-0402-4b94-90e9-c5aa52fe54b6__screenshot01.png
> Changed Check Box Text
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/b7fc88be-6e22-4671-9b6b-60e113cc42f1__screenshot02.png
> Frame around Practise Direction
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/85ca885d-5f60-46da-a5a1-c892564f9c70__screenshot03.png
> Practice Selection with three Frames
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/8e0b5767-da65-4815-9348-097b25da2ffa__screenshot04.png
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>