Re: Review Request 129533: expand all in tree view

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129533/#review101061
-----------------------------------------------------------



Using * to expand all is well-known under Windows. But I think it's a risk and a usability fault since one key is often accidentally pressed and opening a deep tree often crashes the app. Better we introduce our own shortcut, as Thomas says, ctrl+ * (use the numpad since the other * is shift+ + on a keyboard with German layout) would be appropriate. You should also consider a two-step expand feature with ctrl+ * to open all nodes one level below (and keep the rest closed or untouched) and shift+ctrl+ * to open every node below the selection/or all of the tree. 

Hm, numpad is awkward... Anyway, I agree with Thomas that this shortcut(s) needs to get added to the context menu in order to make them transparent to the user.

And eventually, as a user I'd expect this behavior to be consistent over all apps. So we should introduce the expand feature as a core function.

- Heiko Tietze


On Nov. 22, 2016, 8:04 p.m., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129533/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 8:04 p.m.)
> 
> 
> Review request for Dolphin and KDE Usability.
> 
> 
> Bugs: 196772
>     https://bugs.kde.org/show_bug.cgi?id=196772
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This allows the user to expand all expandable items in tree view by pressing '*'.  I've implemented this by adding expandAll() to the model, which is similar to QTreeView::expandAll(). The screenshots demonstrates the results after each press of '*'.  
> 
> Later, I can implement collapseAll() similarly, as well as the ability to expand selected folders if someone wants to tell me how those functionalities should be exposed (e.g., via menus or keypresses).
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemmodel.h 8a0df72 
>   src/kitemviews/kfileitemmodel.cpp 05f85a6 
>   src/kitemviews/kitemlistcontroller.cpp 1c86ff0 
>   src/kitemviews/kitemmodelbase.h bd5ca1d 
>   src/kitemviews/kitemmodelbase.cpp bf41b1c 
> 
> Diff: https://git.reviewboard.kde.org/r/129533/diff/
> 
> 
> Testing
> -------
> 
> manual testing, and make test passes
> 
> 
> File Attachments
> ----------------
> 
> screen1
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/22/a976337d-1537-40ca-97e4-925e8b603654__snapshot1.png
> screen2
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/22/b671f80a-455c-455c-8aa1-f1959a6d0c8b__snapshot2.png
> screen3
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/22/4a3770e9-7134-4d26-a5be-c66168a80252__snapshot3.png
> screen4
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/22/fe8a3788-f9ef-48bd-ba12-352a96e7de7b__snapshot4.png
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>