Re: Review Request 129607: Display Application version in About dialog header

Jean-Baptiste Mardelle <[email protected]>
Newsgroups gmane.comp.kde.usability,gmane.comp.kde.devel.frameworks
Message-ID <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129607/
-----------------------------------------------------------

(Updated Dec. 3, 2016, 1:39 p.m.)


Review request for KDE Frameworks, KDE Usability and Sebastian Kügler.


Repository: kxmlgui


Description
-------

Last year, a change in kaboutapplicationdialog (review 124133) moved the application version in a separate tab. However for applications, it is really annoying (several Kdenlive users complained and I fully agree) to not have this information clearly displayed as soon as the About dialog is displayed. I understand the interest of having a separate version tab displaying the various underlying libraries used, but I propose to display again the application version in the About dialog header (see screenshot).


Diffs
-----

  src/kaboutapplicationdialog.cpp 156410e 

Diff: https://git.reviewboard.kde.org/r/129607/diff/


Testing
-------

Reverts a recent change, tested and works.


File Attachments (updated)
----------------

About dialog with version
  https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png
Updated patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/ee13cb47-2162-4be7-8255-3dce7f470c2b__about2.png


Thanks,

Jean-Baptiste Mardelle
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.