Re: Review Request 129601: Left mouse double click fires a "go up"

> On Dec. 4, 2016, 8:09 p.m., Emmanuel Pescosta wrote:
> > src/kitemviews/kitemlistcontroller.h, line 243
> > <https://git.reviewboard.kde.org/r/129601/diff/2/?file=486996#file486996line243>
> >
> >     Please rename it to `viewDoubleClicked` because we use view instead of no-item in other places too (e.g. `viewContextMenuRequested`)
> 
> Lorenz Haas wrote:
>     Hm, obviously the "Fixed" button is not the same as the "Done" button in gerrit :) Since it's my first patch for KDE, what is the prefered workflow:
>     
>     a) I load up a new diff and you press "Fixed" if you accept it
>     or
>     b) I say "Fixed" and upload a new diff and you re-open if needed
>     or 
>     c) ???
>     
>     Thanks.

b ;)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129601/#review101276
-----------------------------------------------------------


On Dec. 4, 2016, 9:13 p.m., Lorenz Haas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129601/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2016, 9:13 p.m.)
> 
> 
> Review request for Dolphin and KDE Usability.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Double clicking on the view changes to the folder above the current folder.
> 
> 
> BUG: 307505
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.cpp e5103fd 
>   src/kitemviews/kitemlistcontroller.h b8a93ed 
>   src/kitemviews/kitemlistcontroller.cpp 1c86ff0 
>   src/settings/dolphin_generalsettings.kcfg c724afc 
>   src/settings/navigation/navigationsettingspage.h 5410a4e 
>   src/settings/navigation/navigationsettingspage.cpp e37a35d 
>   src/views/dolphinview.h 0b0d819 
>   src/views/dolphinview.cpp 4105628 
> 
> Diff: https://git.reviewboard.kde.org/r/129601/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lorenz Haas
> 
>