Re: Review Request 129607: Display Application version in About dialog header

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129607/
-----------------------------------------------------------

(Updated Dec. 9, 2016, 7:08 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, KDE Usability and Sebastian Kügler.


Changes
-------

Submitted with commit 3d28036b0ed33ef077c7df6ba30a6d4ceac61884 by Jean-Baptiste Mardelle to branch master.


Repository: kxmlgui


Description
-------

Last year, a change in kaboutapplicationdialog (review 124133) moved the application version in a separate tab. However for applications, it is really annoying (several Kdenlive users complained and I fully agree) to not have this information clearly displayed as soon as the About dialog is displayed. I understand the interest of having a separate version tab displaying the various underlying libraries used, but I propose to display again the application version in the About dialog header (see screenshot).


Diffs
-----

  src/kaboutapplicationdialog.cpp 156410e 

Diff: https://git.reviewboard.kde.org/r/129607/diff/


Testing
-------

Reverts a recent change, tested and works.


File Attachments
----------------

About dialog with version
  https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png
Updated patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/ee13cb47-2162-4be7-8255-3dce7f470c2b__about2.png
renamed to libraries
  https://git.reviewboard.kde.org/media/uploaded/files/2016/12/07/f01ed0c3-1391-48cf-a153-a177d9a7b54a__about3.png


Thanks,

Jean-Baptiste Mardelle