Re: Review Request 129893: Implement continuous search
Albert Astals Cid <[email protected]> Sat, 11 Mar 2017 17:03:50 -0000
| Newsgroups | gmane.comp.kde.usability,gmane.comp.kde.devel.okular |
|---|---|
| Message-ID | <[email protected]> |
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review102793 ----------------------------------------------------------- Someone from accessibility: ping? - Albert Astals Cid On Feb. 9, 2017, 10:08 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 10:08 p.m.) > > > Review request for Okular, KDE Usability and Albert Astals Cid. > > > Repository: okular > > > Description > ------- > > Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers. > > > Diffs > ----- > > core/document.h 1fd86262 > core/document.cpp 41b9ddfe > ui/searchlineedit.cpp baac8be0 > > Diff: https://git.reviewboard.kde.org/r/129893/diff/ > > > Testing > ------- > > Search for something in a pdf, click Next until reaching the end of document. Click again Next and the search starts over from the beginning of the document, without the "Continue from the beginning?" dialog. > > > Thanks, > > Elvis Angelaccio > >