Re: Review Request 130157: Bug 321575 - Change window title when searching

> On June 29, 2017, 7:15 p.m., XY Quadrat wrote:
> > I just noticed that this problem (that the window title is not really descriptive or not translated) is also occurring with e.g. the trash (the window title is simply "trash - / -- Dolphin" and is not translated). So maybe a deeper change is required if we do not want to add an extra case for every situation.

See https://bugs.kde.org/show_bug.cgi?id=211959


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103384
-----------------------------------------------------------


On June 26, 2017, 3:47 p.m., XY Quadrat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130157/
> -----------------------------------------------------------
> 
> (Updated June 26, 2017, 3:47 p.m.)
> 
> 
> Review request for Dolphin, KDE Usability, Elvis Angelaccio, and Emmanuel Pescosta.
> 
> 
> Bugs: 321575
>     https://bugs.kde.org/show_bug.cgi?id=321575
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes creating a helper function currentSearchText() in dolphinviewcontainer.cpp which then gets called from dolphinmainwindow.cpp.
> 
> This fixes BUG: 321575
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.cpp 8d58043 
>   src/dolphinviewcontainer.h e50386a 
>   src/dolphinviewcontainer.cpp 72ced93 
> 
> Diff: https://git.reviewboard.kde.org/r/130157/diff/
> 
> 
> Testing
> -------
> 
> - Disables it iself after search bar is hidden
> - Works with multiple word searches
> 
> 
> Thanks,
> 
> XY Quadrat
> 
>