Re: Review Request 128661: [KTreeWidgetsSearchLineWidget] Use placeholderText instead of separate label

Kai Uwe Broulik <[email protected]> Tue, 29 Aug 2017 20:57:50 -0000

Newsgroups	gmane.comp.kde.devel.frameworks,gmane.comp.kde.usability
Message-ID	<[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128661/
-----------------------------------------------------------

(Updated Aug. 29, 2017, 8:57 nachm.)


Status
------

This change has been discarded.


Review request for KDE Frameworks and KDE Usability.


Repository: kitemviews


Description
-------

This makes the search look identical to virtually any other search box used throughout the workspace.


Diffs
-----

  src/ktreewidgetsearchline.cpp e40a61e 
  src/ktreewidgetsearchlinewidget.cpp 9af4c2e 

Diff: https://git.reviewboard.kde.org/r/128661/diff/


Testing
-------

Tests still pass.

Looks good. I couldn't figure out how to just create the QLineEdit without the intermediate QHBoxLayout.


File Attachments
----------------

Separate "Search:" label gone
  https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/c1e2e92d-2113-4d9f-9594-a2e1db0545c2__Screenshot_20160812_102022.png


Thanks,

Kai Uwe Broulik