Re: Review Request 129893: Implement continuous search

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/
-----------------------------------------------------------

(Updated Sept. 26, 2017, 8:42 p.m.)


Review request for Okular, KDE Usability and Albert Astals Cid.


Changes
-------

Removed the roundtrip core->ui->core


Repository: okular


Description
-------

Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers.


Diffs (updated)
-----

  core/document.cpp 91c623b58d1d98e11afdce73bc3f1f68becd657c 
  ui/searchlineedit.cpp 74e6ef60c06c2d4e0b30be1eb6804545f58bd8eb 


Diff: https://git.reviewboard.kde.org/r/129893/diff/4/

Changes: https://git.reviewboard.kde.org/r/129893/diff/3-4/


Testing
-------

Search for something in a pdf, click Next until reaching the end of document. Click again Next and the search starts over from the beginning of the document, without the "Continue from the beginning?" dialog.


File Attachments
----------------

Before: dialog asks if the search should continue from the beginning.
  https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png
After: always continue search from beginning, with a non-intrusive notification.
  https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png


Thanks,

Elvis Angelaccio