Re: Review Request 130157: Bug 321575 - Change window title when searching

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103788
-----------------------------------------------------------



Reviewboard will be closed soon. Please re-upload this patch on Phabricator: https://phabricator.kde.org/differential/diff/create/

- Elvis Angelaccio


On June 26, 2017, 3:47 p.m., XY Quadrat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130157/
> -----------------------------------------------------------
> 
> (Updated June 26, 2017, 3:47 p.m.)
> 
> 
> Review request for Dolphin, KDE Usability, Elvis Angelaccio, and Emmanuel Pescosta.
> 
> 
> Bugs: 321575
>     https://bugs.kde.org/show_bug.cgi?id=321575
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes creating a helper function currentSearchText() in dolphinviewcontainer.cpp which then gets called from dolphinmainwindow.cpp.
> 
> This fixes BUG: 321575
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.cpp 8d58043 
>   src/dolphinviewcontainer.h e50386a 
>   src/dolphinviewcontainer.cpp 72ced93 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/130157/diff/4/
> 
> 
> Testing
> -------
> 
> - Disables it iself after search bar is hidden
> - Works with multiple word searches
> 
> 
> Thanks,
> 
> XY Quadrat
> 
>