Re: Review Request 130157: Bug 321575 - Change window title when searching
XY Quadrat <[email protected]> Sat, 27 Oct 2018 16:37:29 -0000
| Newsgroups | gmane.comp.kde.usability,gmane.comp.kde.devel.kfm |
|---|---|
| Message-ID | <[email protected]> |
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------
(Updated Oct. 27, 2018, 4:37 p.m.)
Status
------
This change has been discarded.
Review request for Dolphin, KDE Usability, Elvis Angelaccio, and Emmanuel Pescosta.
Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575
Repository: dolphin
Description
-------
When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes creating a helper function currentSearchText() in dolphinviewcontainer.cpp which then gets called from dolphinmainwindow.cpp.
This fixes BUG: 321575
Diffs
-----
src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93
Diff: https://git.reviewboard.kde.org/r/130157/diff/4/
Testing
-------
- Disables it iself after search bar is hidden
- Works with multiple word searches
Thanks,
XY Quadrat