Re: Review Request 129383: Add explicit choices for executables/scripts execution

Don Nguyen <[email protected]> Tue, 24 Sep 2019 20:26:50 -0000
Newsgroups gmane.comp.kde.usability,gmane.comp.kde.devel.kfm
Message-ID <[email protected]> 
--===============0167888614265809379==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129383/
-----------------------------------------------------------

(Updated Sept. 24, 2019, 8:26 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin and KDE Usability.


Bugs: 371837
    https://bugs.kde.org/show_bug.cgi?id=371837


Repository: dolphin


Description
-------

This is the patch for the suggestion proposed by me for bug 371837.


Diffs
-----

  src/settings/general/behaviorsettingspage.h 96eaf3d 
  src/settings/general/behaviorsettingspage.cpp 6d1e8bb 
  src/settings/general/confirmationssettingspage.h e702fe8 
  src/settings/general/confirmationssettingspage.cpp 2419dc0 


Diff: https://git.reviewboard.kde.org/r/129383/diff/2/


Testing
-------

Manual testing.  
make test passed.


File Attachments
----------------

Behavior Settings
  https://git.reviewboard.kde.org/media/uploaded/files/2016/11/12/78938499-c709-4d95-a202-0da21cd34b57__general.png


Thanks,

Don Nguyen


--===============0167888614265809379==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129383/">https://git.reviewboard.kde.org/r/129383/</a>
     </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Dolphin and KDE Usability.</div>
<div>By Don Nguyen.</div>


<p style="color: grey;"><em>Updated Sept. 24, 2019, 8:26 p.m.</em></p>







<div style="margin-top: 1.5em;">
 <strong style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </strong>


 <a href="https://bugs.kde.org/show_bug.cgi?id=371837">371837</a>


</div>



<div style="margin-top: 1.5em;">
 <strong style="color: #575012; font-size: 10pt;">Repository: </strong>
dolphin
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is the patch for the suggestion proposed by me for bug 371837.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Manual testing.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
make test passed.</p></pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/settings/general/behaviorsettingspage.h <span style="color: grey">(96eaf3d)</span></li>

 <li>src/settings/general/behaviorsettingspage.cpp <span style="color: grey">(6d1e8bb)</span></li>

 <li>src/settings/general/confirmationssettingspage.h <span style="color: grey">(e702fe8)</span></li>

 <li>src/settings/general/confirmationssettingspage.cpp <span style="color: grey">(2419dc0)</span></li>

</ul>


<p><a href="https://git.reviewboard.kde.org/r/129383/diff/2/" style="margin-left: 3em;">View Diff</a></p>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/11/12/78938499-c709-4d95-a202-0da21cd34b57__general.png">Behavior Settings</a></li>

</ul>




  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============0167888614265809379==--