Re: Review Request 129533: Dolphin: expand all one level, expand all, and collapse all in details view mode
Don Nguyen <[email protected]> Wed, 25 Sep 2019 20:27:30 -0000
| Newsgroups | gmane.comp.kde.devel.kfm,gmane.comp.kde.usability |
|---|---|
| Message-ID | <[email protected]> |
--===============4179213998554459260==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129533/
-----------------------------------------------------------
(Updated Sept. 25, 2019, 8:27 p.m.)
Status
------
This change has been discarded.
Review request for Dolphin and KDE Usability.
Bugs: 196772
https://bugs.kde.org/show_bug.cgi?id=196772
Repository: dolphin
Description
-------
Implemented functions: Expand, Expand Full, and Collapse All. They are available under the View and Control menus as well as custom toolbar buttons as Thomas explained and are disabled when not in details view mode. They are also available via the context menu only in details view mode. See screenshots.
Expand - If there is a selection, expand the selection once. Otherwise expand everything once.
Expand Full - If there is a selection, expand the selected items completely. Otherwise expand everything completely.
Collapse All - Collapse everything.
Diffs
-----
src/dolphincontextmenu.h f67300d
src/dolphincontextmenu.cpp 58e2f4d
src/dolphinmainwindow.cpp 185db71
src/dolphinui.rc c446656
src/kitemviews/kfileitemmodel.h dc5746a
src/kitemviews/kfileitemmodel.cpp 7e14baf
src/tests/kfileitemmodeltest.cpp 59ff630
src/views/dolphinview.h 5e69fd3
src/views/dolphinview.cpp 63f6252
src/views/dolphinviewactionhandler.h eb375b5
src/views/dolphinviewactionhandler.cpp 273bcdd
Diff: https://git.reviewboard.kde.org/r/129533/diff/14/
Testing
-------
make test passes
manual testing including:
expand all on an Android SDK folder which yielded in 3180 folders, and 30993 files
collapse all on above situation
expand all on a directory that contains a symbolic link to a directory containing itself - operation will stop with error when expansion reaches a path that KCoreDirLister doesn't accept(see looptest screenshot)
changing directories in the middle of an expand all operation
changing directories in the middle of a restore expanded directories operation
canceling in the middle of an expand all operation
canceling in the middle of a restore expanded directories operation
canceling in the middle of an expand all operation or restore expand directory operation, and then expanding an item manually with mouse click
collapse all in the middle of an expand all operation
collapse all in the middle of a restore expanded directories operation
switched view modes and verified items are enabled only in details view mode
File Attachments
----------------
looptest
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/25/f02b7e85-d0b3-4153-ae0d-e86a4ddfc916__looptest.png
context-menu-disabled
https://git.reviewboard.kde.org/media/uploaded/files/2016/12/04/1fcc4412-e5f2-4c31-92bf-b828eea938f7__contextdisabled.png
context-menu-with-selection
https://git.reviewboard.kde.org/media/uploaded/files/2016/12/04/8a4709e5-d674-4f74-8cbc-a71841db7c36__selectioncontextenabled.png
view-menu-enabled
https://git.reviewboard.kde.org/media/uploaded/files/2016/12/04/1ddaa88d-e0aa-441a-a840-5e2cdc06fbf2__viewmenuenabled.png
view submenu
https://git.reviewboard.kde.org/media/uploaded/files/2017/01/23/af06ef13-a5b5-4b09-99dc-a0972fdde63c__viewsubmenu.png
context submenu
https://git.reviewboard.kde.org/media/uploaded/files/2017/01/23/9abdf55d-7846-4725-801c-cbe17e353dd3__contextsubmenu.png
Thanks,
Don Nguyen
--===============4179213998554459260==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129533/">https://git.reviewboard.kde.org/r/129533/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Dolphin and KDE Usability.</div>
<div>By Don Nguyen.</div>
<p style="color: grey;"><em>Updated Sept. 25, 2019, 8:27 p.m.</em></p>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </strong>
<a href="https://bugs.kde.org/show_bug.cgi?id=196772">196772</a>
</div>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implemented functions: Expand, Expand Full, and Collapse All. They are available under the View and Control menus as well as custom toolbar buttons as Thomas explained and are disabled when not in details view mode. They are also available via the context menu only in details view mode. See screenshots.
Expand - If there is a selection, expand the selection once. Otherwise expand everything once.
Expand Full - If there is a selection, expand the selected items completely. Otherwise expand everything completely.
Collapse All - Collapse everything.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">make test passes
manual testing including:
expand all on an Android SDK folder which yielded in 3180 folders, and 30993 files
collapse all on above situation
expand all on a directory that contains a symbolic link to a directory containing itself - operation will stop with error when expansion reaches a path that KCoreDirLister doesn't accept(see looptest screenshot)
changing directories in the middle of an expand all operation
changing directories in the middle of a restore expanded directories operation
canceling in the middle of an expand all operation
canceling in the middle of a restore expanded directories operation
canceling in the middle of an expand all operation or restore expand directory operation, and then expanding an item manually with mouse click
collapse all in the middle of an expand all operation
collapse all in the middle of a restore expanded directories operation
switched view modes and verified items are enabled only in details view mode</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dolphincontextmenu.h <span style="color: grey">(f67300d)</span></li>
<li>src/dolphincontextmenu.cpp <span style="color: grey">(58e2f4d)</span></li>
<li>src/dolphinmainwindow.cpp <span style="color: grey">(185db71)</span></li>
<li>src/dolphinui.rc <span style="color: grey">(c446656)</span></li>
<li>src/kitemviews/kfileitemmodel.h <span style="color: grey">(dc5746a)</span></li>
<li>src/kitemviews/kfileitemmodel.cpp <span style="color: grey">(7e14baf)</span></li>
<li>src/tests/kfileitemmodeltest.cpp <span style="color: grey">(59ff630)</span></li>
<li>src/views/dolphinview.h <span style="color: grey">(5e69fd3)</span></li>
<li>src/views/dolphinview.cpp <span style="color: grey">(63f6252)</span></li>
<li>src/views/dolphinviewactionhandler.h <span style="color: grey">(eb375b5)</span></li>
<li>src/views/dolphinviewactionhandler.cpp <span style="color: grey">(273bcdd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129533/diff/14/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/11/25/f02b7e85-d0b3-4153-ae0d-e86a4ddfc916__looptest.png">looptest</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/04/1fcc4412-e5f2-4c31-92bf-b828eea938f7__contextdisabled.png">context-menu-disabled</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/04/8a4709e5-d674-4f74-8cbc-a71841db7c36__selectioncontextenabled.png">context-menu-with-selection</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/04/1ddaa88d-e0aa-441a-a840-5e2cdc06fbf2__viewmenuenabled.png">view-menu-enabled</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/01/23/af06ef13-a5b5-4b09-99dc-a0972fdde63c__viewsubmenu.png">view submenu</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/01/23/9abdf55d-7846-4725-801c-cbe17e353dd3__contextsubmenu.png">context submenu</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4179213998554459260==--