Re: Review Request 123658: If double-click is on empty area, then invoke back.

Ashish Bansal <[email protected]> Sun, 29 Sep 2019 16:24:28 -0000
Newsgroups gmane.comp.kde.usability,gmane.comp.kde.devel.kfm
Message-ID <[email protected]> 
--===============1827054506737900939==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123658/
-----------------------------------------------------------

(Updated Sept. 29, 2019, 4:24 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin, KDE Usability and Emmanuel Pescosta.


Bugs: 307505
    https://bugs.kde.org/show_bug.cgi?id=307505


Repository: dolphin


Description
-------

If mouse double click is done on the empty area, then go to parent directory.

RR 123929 (kfilewidgets)


Diffs
-----

  src/kitemviews/kitemlistcontroller.h b8a93ed 
  src/kitemviews/kitemlistcontroller.cpp 1c86ff0 
  src/views/dolphinview.h 24b560f 
  src/views/dolphinview.cpp d302358 


Diff: https://git.reviewboard.kde.org/r/123658/diff/4/


Testing
-------

Works fine.


Thanks,

Ashish Bansal


--===============1827054506737900939==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123658/">https://git.reviewboard.kde.org/r/123658/</a>
     </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Dolphin, KDE Usability and Emmanuel Pescosta.</div>
<div>By Ashish Bansal.</div>


<p style="color: grey;"><em>Updated Sept. 29, 2019, 4:24 p.m.</em></p>







<div style="margin-top: 1.5em;">
 <strong style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </strong>


 <a href="https://bugs.kde.org/show_bug.cgi?id=307505">307505</a>


</div>



<div style="margin-top: 1.5em;">
 <strong style="color: #575012; font-size: 10pt;">Repository: </strong>
dolphin
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If mouse double click is done on the empty area, then go to parent directory.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">RR 123929 (kfilewidgets)</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works fine.</p></pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kitemviews/kitemlistcontroller.h <span style="color: grey">(b8a93ed)</span></li>

 <li>src/kitemviews/kitemlistcontroller.cpp <span style="color: grey">(1c86ff0)</span></li>

 <li>src/views/dolphinview.h <span style="color: grey">(24b560f)</span></li>

 <li>src/views/dolphinview.cpp <span style="color: grey">(d302358)</span></li>

</ul>


<p><a href="https://git.reviewboard.kde.org/r/123658/diff/4/" style="margin-left: 3em;">View Diff</a></p>










  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============1827054506737900939==--