Re: git status --porcelain error?

On Monday, 9 January 2017 14:34:53 CET René J.V. Bertin wrote:
> On Monday January 9 2017 12:46:16 Kevin Funk wrote:
> >I don't think that's necessary. Showing the git output as-is is already
> >quite verbose.
> 
> I was thinking about something like this:
> 
> @@ -244,8 +244,8 @@ void DVcsJob::slotProcessError( QProcess::ProcessError
> err ) qCDebug(VCS) << "Found an error while running" << displayCommand <<
> ":" << errorValue << "Exit code is:" << d->childproc->exitCode();
> qCDebug(VCS) << "Error:" << completeErrorText;
> -    displayOutput(QString::fromLocal8Bit(d->errorOutput));
> -    d->model->appendLine(i18n("Command finished with error %1.",
> errorValue)); +//    
> displayOutput(QString::fromLocal8Bit(d->errorOutput));
> +    d->model->appendLine(i18n("%1 (%2).", completeErrorText, errorValue));
> 
>      if(verbosity()==Silent) {
>          setVerbosity(Verbose);

Hmm, that actually makes sense yep. I guess it's an oversight that 
`completeErrorText` is not shown in the UI. It's an translated string after 
all.

Will apply that later.

> >What /could/ make sense is to elaborate what `FailedToStart` means for the
> >user...
> 
> Yeah, but that's not going to tell *me* anything. I don't need hints what
> the error means but why it happens ;)

Just showing "FailedToStart doesn't really help the user though. It needs be 
more descriptive. 

I'll look into it.

Thanks,
Kevin

-- 
Kevin Funk | [email protected] | http://kfunk.org

-----BEGIN PGP SIGNATURE-----

iEYEABECAAYFAlhzpHEACgkQxkz1axPKzl2lqgCgr+C0T7bkHw3JQSkKKU4zjYXT
Q7IAnjjqp1hhqFhmMJkwbYrhv3zwqkyP
=S8vP
-----END PGP SIGNATURE-----