Re: Review Request 128419: Fix MPRIS2 DesktopEntry value
Antonio Rojas <[email protected]>
| Newsgroups | gmane.comp.kde.users.multimedia |
|---|---|
| Message-ID | <[email protected]> |
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128419/
-----------------------------------------------------------
(Updated July 11, 2016, 10:13 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Multimedia.
Changes
-------
Submitted with commit f3930e6d7d782d67ce16eac34acbc71e6360731e by Michael Pyne on behalf of Antonio Rojas to branch master.
Bugs: 365275
http://bugs.kde.org/show_bug.cgi?id=365275
Repository: juk
Description
-------
According to the MPRIS2 spec, the DesktopEntry value should be "the basename of the .desktop file" [1], not the desktop-file-id. So for juk it should be "juk" and not "kde4-juk", regardless of where the desktop file is installed. This fixes displaying MPRIS controls in the juk taskbar tooltip in Plasma 5.7
[1] https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry
Diffs
-----
mpris2/mediaplayer2.cpp 2514ac0
Diff: https://git.reviewboard.kde.org/r/128419/diff/
Testing
-------
Thanks,
Antonio Rojas
_______________________________________________
kde-multimedia mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-multimedia