Re: Review Request 118989: KCDDB::Client::lookup() make sure all pending lookup tasks are cleared before starting a new lookup
Frank Schaefer <[email protected]>
| Newsgroups | gmane.comp.kde.users.multimedia |
|---|---|
| Message-ID | <[email protected]> |
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118989/ ----------------------------------------------------------- (Updated July 29, 2016, 7:48 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Multimedia. Changes ------- Submitted with commit 415a3f7b207de9074cde1701dc71abb1b0336e22 by Leslie Zhai to branch kf5. Repository: libkcddb Description ------- Client::lookup() cancels a pending CDDB lookup and starts a new one. With musicbrainz5 is enabled always two lookup tasks are queued for a CD data lookup: one for musicbrainz and another one for freedb. If the first task fails, the second one is started. Client::lookup() currently only clears the active lookup task and forgets to clear the queued tasks. As a result, an old/outdated lookup task (for a previous CD) may be started. Diffs ----- libkcddb/client.cpp 6ceb0f5 Diff: https://git.reviewboard.kde.org/r/118989/diff/ Testing ------- yes Thanks, Frank Schaefer _______________________________________________ kde-multimedia mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-multimedia