Re: Review Request 128998: fix MPRIS DesktopEntry after .desktop file rename

Luigi Toscano <[email protected]>
Newsgroups gmane.comp.kde.users.multimedia
Message-ID <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128998/#review99408
-----------------------------------------------------------


Ship it!




Woops, sorry, I missed it when I used grep.
This is the type of changes which should probably go in directly.

- Luigi Toscano


On Sept. 22, 2016, 11:49 a.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128998/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 11:49 a.m.)
> 
> 
> Review request for KDE Multimedia and Luigi Toscano.
> 
> 
> Repository: juk
> 
> 
> Description
> -------
> 
> The DesktopEntry broadcast by MPRIS needs to match the .desktop file name, otherwise player controls don't work in Plasma taskbar tooltips.
> 
> 
> Diffs
> -----
> 
>   mpris2/mediaplayer2.cpp 34f7ac7 
> 
> Diff: https://git.reviewboard.kde.org/r/128998/diff/
> 
> 
> Testing
> -------
> 
> MPRIS controls work in Plasma taskbar tooltips
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.