Re: Review Request 129401: Don't hard-code CMAKE_VERBOSE_MAKEFILE=OFF
Heiko Becker <[email protected]>
| Newsgroups | gmane.comp.kde.users.multimedia |
|---|---|
| Message-ID | <[email protected]> |
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129401/ ----------------------------------------------------------- (Updated Nov. 14, 2016, 2:32 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Multimedia and Thomas Eschenbacher. Changes ------- Submitted with commit 91dbf4247d635d3fae971de800f30f9f1991f523 by Heiko Becker to branch master. Repository: kwave Description ------- It's IMHO annoying because you can't override it via "cmake -DCMAKE_VERBOSE_MAKEFILE=ON". As a source based distro we have it enabled by default for cmake based packages in order to more easily see what is wrong in case of a build failure. Diffs ----- CMakeLists.txt 1632847 Diff: https://git.reviewboard.kde.org/r/129401/diff/ Testing ------- Passing -DCMAKE_VERBOSE_MAKEFILE now has an effect. Thanks, Heiko Becker