Re: Review Request 129651: [dragon] Inhibit powersave

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129651/#review101513
-----------------------------------------------------------


Fix it, then Ship it!




Looks good, please still add a comment (unless you verified that these two steps in fact inhibit screen power saving).


src/app/mainWindow.cpp (line 846)
<https://git.reviewboard.kde.org/r/129651/#comment67950>

    Add a comment above here
    ```
    // TODO: inhibit screen sleep. No viable API found.
    //   https://git.reviewboard.kde.org/r/129651
    ```


- Harald Sitter


On Dec. 20, 2016, 6:06 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129651/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 6:06 a.m.)
> 
> 
> Review request for KDE Multimedia and Harald Sitter.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> Since solid power api is not released, i use freedesktop dbus to fit other desktop power managers
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8f84c85 
>   src/app/CMakeLists.txt 303e06e 
>   src/app/mainWindow.cpp 01a4545 
> 
> Diff: https://git.reviewboard.kde.org/r/129651/diff/
> 
> 
> Testing
> -------
> 
> *Harald master was not merged (16.04 / 16.08 to master) -> it has fresh bugreports for fixed issues.
> Last merge to 16.08
> 2016-04-18	Merge branch 'Applications/16.04'	Harald Sitter
> after that in brach 16.04
> 2016-04-26	Hide toolbar on multiscreen setup	Anthony Fieroni
> 2016-04-20	Don't try to resize maximized window	Anthony Fieroni
> 2016-04-19	MPRIS2 property 'Identity' to match desktop file entry	Anthony Fieroni
> 
> Do you want to merge them or you will ship ?
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>