Re: Review Request 129673: [recentlyPLayedList] Add keyboard shortcuts

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129673/#review101550
-----------------------------------------------------------




src/app/recentlyPlayedList.cpp (line 46)
<https://git.reviewboard.kde.org/r/129673/#comment67990>

    As previously noted. Please initalize one object after the other.
    
    clear = new
    clear.setIcon
    clear.setShortcut
    connect(clear..)
    
    remove = new
    remove.setIcon
    remove.setShortcut
    connect(remove...)
    
    addActions({remove, clear})



src/app/recentlyPlayedList.cpp (line 95)
<https://git.reviewboard.kde.org/r/129673/#comment67991>

    This is now missing the `if (!currentItem())` guard? ;)


- Harald Sitter


On Dec. 23, 2016, 5:40 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129673/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2016, 5:40 a.m.)
> 
> 
> Review request for KDE Multimedia and Harald Sitter.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> Ability to remove item and clear list from keyboard shortcut
> 
> 
> Diffs
> -----
> 
>   src/app/recentlyPlayedList.cpp 2c25e7f 
> 
> Diff: https://git.reviewboard.kde.org/r/129673/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Actions
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/20/fad5b9ab-9ffb-4220-a0f4-5a25845c6507__Screenshot_20161220_070541.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>