Re: Review Request 129695: [dragon] Simplified transition between different views

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129695/
-----------------------------------------------------------

(Updated Jan. 2, 2017, 3:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Multimedia and Harald Sitter.


Changes
-------

Submitted with commit b8a1d709d17c90dabc352af4aa4af395ee5d4938 by Anthony Fieroni to branch Applications/16.12.


Repository: dragon


Description
-------

Patch was rejected from reviewboard, see attached file and link to pastebin for pretty format https://paste.kde.org/pm1yzkjdl


Diffs
-----

  src/app/recentlyPlayedList.cpp 2c25e7f 
  src/app/stateChange.cpp 7bf4038 

Diff: https://git.reviewboard.kde.org/r/129695/diff/


Testing
-------

Fixed one frame blinking audioview before video starts, it's because information (hasVideo) is not resolved immediately after a media object gets a new source.
Tested scenarios:

Play video file -> videoview -> wait to auto end -> loadview
Play video file -> videoview -> press stop -> loadview
Play video file -> videoview -> press Play media (preview) -> wait to end -> loadview
Play video file -> videoview -> press Play media (preview) -> press stop -> loadview

Play audio file -> audioview -> wait to auto end -> loadview
Play audio file -> audioview -> press stop -> loadview
Play audio file -> audioview -> press Play media -> wait to end -> loadview
Play audio file -> audioview -> press Play media -> press stop -> loadview


File Attachments
----------------

real patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/12/23/87b20eea-30b9-4a6c-8915-bfbc0f4f3cd8__simple.patch


Thanks,

Anthony Fieroni