Re: Review Request 129923: [ffmpegthumbs] Remove the 1px border from thumbnails

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129923/#review102875
-----------------------------------------------------------


Ship it!




Ship It!

- Emmanuel Pescosta


On Feb. 5, 2017, 2:23 a.m., Diego Soenens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129923/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2017, 2:23 a.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Repository: ffmpegthumbs
> 
> 
> Description
> -------
> 
> This is part of https://git.reviewboard.kde.org/r/129921/.
> 
> Returning DrawFrame in flags results in a 1px black and white border getting added to the thumbnail while returning None does not.
> There is no reason why it should be adding a border.
> Especially since this thumbnail creator generates images that could (and should IMO) be treated the same as thumbnails from, say, image files like wallpapers etc.
> 
> 
> Diffs
> -----
> 
>   ffmpegthumbnailer.cpp e8604e417979fecf9af5edda67cf8f1dbfc0f13c 
> 
> Diff: https://git.reviewboard.kde.org/r/129923/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Diego Soenens
> 
>