Re: Review Request 130089: [libkcompactdisc] Fix build with and without Alsa

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130089/#review103053
-----------------------------------------------------------



Whatever the problem you are tyring to fix is, you need to fix it properly by supposedly making sure config-alsa.h is included where needed. Adding global definitions is a hack.


src/CMakeLists.txt (line 16)
<https://git.reviewboard.kde.org/r/130089/#comment68552>

    This is wrong. HAVE_ALSA is meant to be a variable, which is then turned into a define via config-alsa.h.cmake



src/CMakeLists.txt (line 17)
<https://git.reviewboard.kde.org/r/130089/#comment68553>

    Should indent with spaces



src/CMakeLists.txt (line 18)
<https://git.reviewboard.kde.org/r/130089/#comment68554>

    anonymous `endif()` please


- Harald Sitter


On April 16, 2017, 8:22 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130089/
> -----------------------------------------------------------
> 
> (Updated April 16, 2017, 8:22 p.m.)
> 
> 
> Review request for KDE Multimedia and Leslie Chak.
> 
> 
> Repository: libkcompactdisc
> 
> 
> Description
> -------
> 
> Package currently fails to link against Alsa, but also fails to configure without Alsa.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt b25c7d7 
> 
> Diff: https://git.reviewboard.kde.org/r/130089/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>