Re: Review Request 130162: Why QDialogButtonBox::Close could not emit closeEvent?

Leslie Zhai <[email protected]> Mon, 19 Jun 2017 08:20:57 -0000
Newsgroups gmane.comp.kde.users.multimedia
Message-ID <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130162/
-----------------------------------------------------------

(Updated 六月 19, 2017, 4:20 p.m.)


Review request for KDE Multimedia, Albert Astals Cid and Anthony Fieroni.


Changes
-------

Fixed!


Bugs: 381368
    http://bugs.kde.org/show_bug.cgi?id=381368


Repository: k3b


Description
-------

Dear,

As Dr. Chaptian reported "do not show again" from system configuration problems dialog is not remembered, so I simply added `slotClose` to write the entry for K3b's KConfigGroup. but I have no idea why QDialogButtonBox::Close could not emit closeEvent, not need to connect, perhaps old Qt v4.x was able to work?

Regards,
Leslie Zhai


Diffs (updated)
-----

  src/k3bsystemproblemdialog.h b45f2f80c 
  src/k3bsystemproblemdialog.cpp 9dfc50c1d 

Diff: https://git.reviewboard.kde.org/r/130162/diff/


Testing
-------


Thanks,

Leslie Zhai