Re: Review Request 121731: Make Juk mpris2 metadata closer match vlc / dragon / amarok metadata with empty fields

James Smith <[email protected]> Sat, 07 Oct 2017 02:32:55 -0000

Newsgroups	gmane.comp.kde.users.multimedia
Message-ID	<[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121731/
-----------------------------------------------------------

(Updated Oct. 7, 2017, 2:32 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Multimedia.


Changes
-------

Submitted with commit 90f1694a3efc631871545e05b1f3343849f067fc by Michael Pyne to branch master.


Repository: juk


Description
-------

Juk behaviour with empty metadata fields was to include the field irregardless of whether it was empty or not. This patch follows vlc, dragon, and amarok behaviour which is to just omit the field when there is no information.


Diffs
-----

  mpris2/mediaplayer2player.cpp 080b43fe2b47fa2b0f2e37ad15695bfcf33efe5e 


Diff: https://git.reviewboard.kde.org/r/121731/diff/1/


Testing
-------

Compile, run. Test with files with appropriate metadata characteristics.


Thanks,

James Smith