Re: D21154: Automatically run pg_upgrade when major PostgreSQL is detected

On Tuesday, 14 May 2019 10:49:41 CEST Ianseeks wrote:
> On Sunday, 12 May 2019 13:56:07 BST Daniel Vrátil wrote:
> > dvratil created this revision.
> > Herald added a project: KDE PIM.
> > Herald added a subscriber: kde-pim.
> > dvratil requested review of this revision.
> > 
> > REVISION SUMMARY
> > 
> >   This implements detection of version of the db_data cluster and the
> >   currently installed Postgres version (on Linux for now, only), and
> >   upgrading the cluster when Postgres major version upgrade is detected.
> >   
> >   This should make it more comfortable for users to use Akonadi with
> >   Postgres
> >   since they no longer have to care about Postgres upgrades. It upgrade
> >   will fail if we fail to find executables for the previous Postgres
> >   server version (the one from which we are upgrading), which may differ
> >   between distributions and usually requires an additional package to be
> >   installed.
> 
> Sounds great. Is there any warning about the setting in Alternatives if its
> set to not upgrade?

Not sure what do you mean by Alternatives? There's no option in Akonadi to 
disable the storage upgrade. If your Postgres package is set to not be updated 
by your package manager, then Akonadi won't have any reason to do any upgrade 
:-)

> > TEST PLAN
> > 
> >   Tested on Fedora, upgrading from Postgres 10 to 11
> > 
> > REPOSITORY
> > 
> >   R165 Akonadi
> > 
> > BRANCH
> > 
> >   master
> > 
> > REVISION DETAIL
> > 
> >   https://phabricator.kde.org/D21154
> > 
> > AFFECTED FILES
> > 
> >   src/server/storage/dbconfigpostgresql.cpp
> >   src/server/storage/dbconfigpostgresql.h
> > 
> > To: dvratil
> > Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss,
> > dvratil


-- 
Daniel Vrátil
www.dvratil.cz | [email protected]
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEECr36VaTmvqmag+qXTWlVeuyxNoMFAlzat4UACgkQTWlVeuyx
NoPdOw//cidhlrjdx+Y5Gf+/Q4RptwLDfVn2Gnw2yWkdE6M2rb1LKmSDT3+mNlKj
k6rRGmAupE7jg7qt5fzO+mWjDqYSsyxjYcRIUwFNGriA9NFXOIlRjSGkn/rLyk9j
uTPjTO9GbZOke1n9hS3MuGvsu6YNwSz/MjRK25rmXe/wMrqdJngy7LrwRK2FFumY
6U6tf+pmMJYMo+kYtshmxmxU6ZvffloLsLNrypkev32znK3+R7j4kyAlWFuJIRdq
RB/DtWfau0j1QgEDS5zSdO/g+3RlYHv/lJ02jsnziRbRuOd93k/bFbKhwS0hpCJ0
Jix/JxYWqEsl60qLCdxtzYeKzktcErkIBZLJ6OXRl5r5QFxZUNtk8ilzOHBZ9svQ
0qUUu8xu55C76M+e8gbYq2Ytwa8g4GKvrl3/z6xLWU1tLtkf4IVPZ5s5ljQDnj5a
VpMAxS2x2NEjBb5kQkMQti0gFCrTWw1jJB9HwPfaJGi1nVHv6bOcHDR3hMLvPx2m
sPPFRf+PE146kpIH8JDf5L44zmmRV2Hl7XGRlK4AEjONWO4dWJJTncacrIuZMCDH
W7hjeZqq3kQvzZhYFfrxpF1B0ex+iHNKV0rx8fNc+NLkK+6sVn0PO8lIhBuKvHne
T2NEWQQQrfL3TaByUEwYAcfH7tFTmn151u6quifBzKhsybYCvHY=
=qBV1
-----END PGP SIGNATURE-----