Re: Replace gethostbyname with getaddrinfo

This is a multi-part message in MIME format.
--------------fdWc8qGvvyimcOMzKIvV4rBa
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 7/13/23 16:48, Benson Muite wrote:
> On 7/13/23 16:37, Mike Aubury wrote:
>> If you can do a patch, I'd be happy to apply it - I dont think those
>> functions will be called by the vast majority of users.
>>
> Will send a patch
Initial patch is attached based on release 1.6.1

It requests ipv4 addresses, though one can later update to using both
ipv4 and ipv6 addresses
>> If you want - I can give you developer access and you can update
>> whatever you want :)
>>
> Thanks. May need to review my changes though.
>> On Thu, 13 Jul 2023 at 14:21, Benson Muite <[email protected]
>> <mailto:[email protected]>> wrote:
>>
>>     The files:
>>     lib/libaubit4gl/gui.c
>>     lib/libui/ui_json/uilib/comms.c
>>     lib/libui/ui_xml/uilib/comms.c
>>     lib/libui/ui_highlevel/remote_client/pipeclient.c
>>
>>     contain gethostbyname, would it be possible to replace this with
>>     getaddrinfo?
>>
>>     Configure script will also need to be updated accordingly.  Can send a
>>     patch with a possible implementation if it would be considered.
>>
>>

--------------fdWc8qGvvyimcOMzKIvV4rBa
Content-Type: text/x-patch; charset=UTF-8; name="getaddrinfo.patch"
Content-Disposition: attachment; filename="getaddrinfo.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtcnVOIGF1Yml0NGdsc3JjL2NvbmZpZ3VyZS5pbiBhdWJpdDRnbHNyYy11cGRhdGVk
L2NvbmZpZ3VyZS5pbgotLS0gYXViaXQ0Z2xzcmMvY29uZmlndXJlLmluCTIwMjItMTItMzEg
MTQ6MzQ6MTAuMDAwMDAwMDAwICswMzAwCisrKyBhdWJpdDRnbHNyYy11cGRhdGVkL2NvbmZp
Z3VyZS5pbgkyMDIzLTA3LTI2IDE4OjM0OjI4LjA1MTU5OTI4MSArMDMwMApAQCAtOTY1OSw3
ICs5NjU5LDcgQEAKIAlBQ19GVU5DX01FTUNNUAogCUFDX1RZUEVfU0lHTkFMCiAJQUNfRlVO
Q19WUFJJTlRGCi0JQUNfQ0hFQ0tfRlVOQ1MoW2Zsb29yIGdldGhvc3RieW5hbWUgaW5ldF9u
dG9hIG1lbXNldCBwb3cgcHV0ZW52IHJlX2NvbXAgcmVnY29tcCBzZXRsb2NhbGUgc3RyY2Fz
ZWNtcCBzdHJjaHIgc3RyZHVwIHN0cm5jYXNlY21wIHN0cnJjaHIgc3Ryc3RyIHN0cnRvbCBp
bmRleCByaW5kZXggcG9wZW4gc25wcmludGYgdnNucHJpbnRmIHNpZ2FjdGlvbiBnZXR0aW1l
b2ZkYXkgdHJ1bmMgc2xlZXAgXSkKKwlBQ19DSEVDS19GVU5DUyhbZmxvb3IgZ2V0YWRkcmlu
Zm8gaW5ldF9udG9hIG1lbXNldCBwb3cgcHV0ZW52IHJlX2NvbXAgcmVnY29tcCBzZXRsb2Nh
bGUgc3RyY2FzZWNtcCBzdHJjaHIgc3RyZHVwIHN0cm5jYXNlY21wIHN0cnJjaHIgc3Ryc3Ry
IHN0cnRvbCBpbmRleCByaW5kZXggcG9wZW4gc25wcmludGYgdnNucHJpbnRmIHNpZ2FjdGlv
biBnZXR0aW1lb2ZkYXkgdHJ1bmMgc2xlZXAgXSkKIAogCSNzZWxlY3QoKSBhbmQgaW5kZXgo
KSBhcmUgdXNlZCBpbiBKYWJiZXIgCiAJI3RoZXJlIGlzIGFwcHJlbnRseSBhbiBpbmRleCgp
IGZ1bmMgc29tZXdoZXJlIGluIGxpYmF1Yml0NGdsIG9yIGluIHNvbWUgbGliCmRpZmYgLXJ1
TiBhdWJpdDRnbHNyYy9saWIvbGliYXViaXQ0Z2wvZ3VpLmMgYXViaXQ0Z2xzcmMtdXBkYXRl
ZC9saWIvbGliYXViaXQ0Z2wvZ3VpLmMKLS0tIGF1Yml0NGdsc3JjL2xpYi9saWJhdWJpdDRn
bC9ndWkuYwkyMDE4LTAyLTA3IDExOjA4OjA5LjAwMDAwMDAwMCArMDMwMAorKysgYXViaXQ0
Z2xzcmMtdXBkYXRlZC9saWIvbGliYXViaXQ0Z2wvZ3VpLmMJMjAyMy0wNy0yNyAxODo0MTow
NC44MzE1NDUwMjAgKzAzMDAKQEAgLTE2NywxOSArMTY3LDI0IEBACiBzdGF0aWMgc3RydWN0
IGluX2FkZHIgKgogYXRvYWRkciAoY2hhciAqYWRkcmVzcykKIHsKLSAgc3RydWN0IGhvc3Rl
bnQgKmhvc3Q7CiAgIHN0YXRpYyBzdHJ1Y3QgaW5fYWRkciBzYWRkcjsKKyAgc3RydWN0IGFk
ZHJpbmZvIGhpbnRzLCAqcmVzLCAqcDsKIAorICBtZW1zZXQoJmhpbnRzLCAwLCBzaXplb2Yo
aGludHMpKTsKKyAgaGludHMuYWlfZmFtaWx5ID0gQUZfSU5FVDsKKyAgaW50IHN0YXR1czsK
ICAgLy8gRmlyc3QgdHJ5IGl0IGFzIGFhYS5iYmIuY2NjLmRkZC4KICAgc2FkZHIuc19hZGRy
ID0gaW5ldF9hZGRyIChhZGRyZXNzKTsKICAgaWYgKHNhZGRyLnNfYWRkciAhPSAtMSkKICAg
ICB7CiAgICAgICByZXR1cm4gJnNhZGRyOwogICAgIH0KLSAgaG9zdCA9IGdldGhvc3RieW5h
bWUgKGFkZHJlc3MpOwotICBpZiAoaG9zdCAhPSBOVUxMKQorICBzdGF0dXMgPSBnZXRhZGRy
aW5mbyhhZGRyZXNzLCBOVUxMLCAmaGludHMsICZyZXMpOworICBpZiAoc3RhdHVzID09IDAp
CiAgICAgewotICAgICAgcmV0dXJuIChzdHJ1Y3QgaW5fYWRkciAqKSAqaG9zdC0+aF9hZGRy
X2xpc3Q7CisgICAgICBzdHJ1Y3QgaW5fYWRkciAqaXB2ID0gKHN0cnVjdCBpbl9hZGRyICop
cmVzLT5haV9hZGRyOworICAgICAgc3RydWN0IGluX2FkZHIgKmFkZHIgPSAmKGlwdi0+c2lu
X2FkZHIpOworICAgICAgcmV0dXJuIGFkZHI7CiAgICAgfQogICByZXR1cm4gKHN0cnVjdCBp
bl9hZGRyICopMDsKIH0KZGlmZiAtcnVOIGF1Yml0NGdsc3JjL2xpYi9saWJ1aS91aV9oaWdo
bGV2ZWwvcmVtb3RlX2NsaWVudC9waXBlY2xpZW50LmMgYXViaXQ0Z2xzcmMtdXBkYXRlZC9s
aWIvbGlidWkvdWlfaGlnaGxldmVsL3JlbW90ZV9jbGllbnQvcGlwZWNsaWVudC5jCi0tLSBh
dWJpdDRnbHNyYy9saWIvbGlidWkvdWlfaGlnaGxldmVsL3JlbW90ZV9jbGllbnQvcGlwZWNs
aWVudC5jCTIwMTgtMDItMDcgMTE6MDg6MTUuMDAwMDAwMDAwICswMzAwCisrKyBhdWJpdDRn
bHNyYy11cGRhdGVkL2xpYi9saWJ1aS91aV9oaWdobGV2ZWwvcmVtb3RlX2NsaWVudC9waXBl
Y2xpZW50LmMJMjAyMy0wNy0yNyAxODo0MDoxOC43MDc3MTY2NzAgKzAzMDAKQEAgLTY1LDgg
KzY1LDEyIEBACiBzdGF0aWMgc3RydWN0IGluX2FkZHIgKgogaW50ZXJuYWxfYXRvYWRkciAo
Y2hhciAqYWRkcmVzcykKIHsKLSAgc3RydWN0IGhvc3RlbnQgKmhvc3Q7CiAgIHN0YXRpYyBz
dHJ1Y3QgaW5fYWRkciBzYWRkcjsKKyAgc3RydWN0IGFkZHJpbmZvIGhpbnRzLCAqcmVzLCAq
cDsKKworICBtZW1zZXQoJmhpbnRzLCAwLCBzaXplb2YoaGludHMpKTsKKyAgaGludHMuYWlf
ZmFtaWx5ID0gQUZfSU5FVDsKKyAgaW50IHN0YXR1czsKIAogICAvLyBGaXJzdCB0cnkgaXQg
YXMgYWFhLmJiYi5jY2MuZGRkLgogICBzYWRkci5zX2FkZHIgPSBpbmV0X2FkZHIgKGFkZHJl
c3MpOwpAQCAtNzQsMTAgKzc4LDEyIEBACiAgICAgewogICAgICAgcmV0dXJuICZzYWRkcjsK
ICAgICB9Ci0gIGhvc3QgPSBnZXRob3N0YnluYW1lIChhZGRyZXNzKTsKLSAgaWYgKGhvc3Qg
IT0gTlVMTCkKKyAgc3RhdHVzID0gZ2V0YWRkcmluZm8oYWRkcmVzcywgTlVMTCwgJmhpbnRz
LCAmcmVzKTsKKyAgaWYgKHN0YXR1cyA9PSAwKQogICAgIHsKLSAgICAgIHJldHVybiAoc3Ry
dWN0IGluX2FkZHIgKikgKmhvc3QtPmhfYWRkcl9saXN0OworICAgICAgc3RydWN0IGluX2Fk
ZHIgKmlwdiA9IChzdHJ1Y3QgaW5fYWRkciAqKXJlcy0+YWlfYWRkcjsKKyAgICAgIHN0cnVj
dCBpbl9hZGRyICphZGRyID0gJihpcHYtPnNpbl9hZGRyKTsKKyAgICAgIHJldHVybiBhZGRy
OwogICAgIH0KICAgcmV0dXJuIChzdHJ1Y3QgaW5fYWRkciAqKSAwOwogfQpkaWZmIC1ydU4g
YXViaXQ0Z2xzcmMvbGliL2xpYnVpL3VpX2pzb24vdWlsaWIvY29tbXMuYyBhdWJpdDRnbHNy
Yy11cGRhdGVkL2xpYi9saWJ1aS91aV9qc29uL3VpbGliL2NvbW1zLmMKLS0tIGF1Yml0NGds
c3JjL2xpYi9saWJ1aS91aV9qc29uL3VpbGliL2NvbW1zLmMJMjAxOC0wMi0wNyAxMTowODox
NS4wMDAwMDAwMDAgKzAzMDAKKysrIGF1Yml0NGdsc3JjLXVwZGF0ZWQvbGliL2xpYnVpL3Vp
X2pzb24vdWlsaWIvY29tbXMuYwkyMDIzLTA3LTI3IDE4OjQwOjU1LjA4ODU4MTI3OCArMDMw
MApAQCAtOTcsMTkgKzk3LDI0IEBACiBzdGF0aWMgc3RydWN0IGluX2FkZHIgKgogYXRvYWRk
ciAoY2hhciAqYWRkcmVzcykKIHsKLSAgc3RydWN0IGhvc3RlbnQgKmhvc3Q7CiAgIHN0YXRp
YyBzdHJ1Y3QgaW5fYWRkciBzYWRkcjsKKyAgc3RydWN0IGFkZHJpbmZvIGhpbnRzLCAqcmVz
LCAqcDsKIAorICBtZW1zZXQoJmhpbnRzLCAwLCBzaXplb2YoaGludHMpKTsKKyAgaGludHMu
YWlfZmFtaWx5ID0gQUZfSU5FVDsKKyAgaW50IHN0YXR1czsKICAgLy8gRmlyc3QgdHJ5IGl0
IGFzIGFhYS5iYmIuY2NjLmRkZC4KICAgc2FkZHIuc19hZGRyID0gaW5ldF9hZGRyIChhZGRy
ZXNzKTsKICAgaWYgKHNhZGRyLnNfYWRkciAhPSAtMSkKICAgICB7CiAgICAgICByZXR1cm4g
JnNhZGRyOwogICAgIH0KLSAgaG9zdCA9IGdldGhvc3RieW5hbWUgKGFkZHJlc3MpOwotICBp
ZiAoaG9zdCAhPSBOVUxMKQorICBzdGF0dXMgPSBnZXRhZGRyaW5mbyhhZGRyZXNzLCBOVUxM
LCAmaGludHMsICZyZXMpOworICBpZiAoc3RhdHVzID09IDApCiAgICAgewotICAgICAgcmV0
dXJuIChzdHJ1Y3QgaW5fYWRkciAqKSAqaG9zdC0+aF9hZGRyX2xpc3Q7CisgICAgICBzdHJ1
Y3QgaW5fYWRkciAqaXB2ID0gKHN0cnVjdCBpbl9hZGRyICopcmVzLT5haV9hZGRyOworICAg
ICAgc3RydWN0IGluX2FkZHIgKmFkZHIgPSAmKGlwdi0+c2luX2FkZHIpOworICAgICAgcmV0
dXJuIGFkZHI7CiAgICAgfQogICByZXR1cm4gKHN0cnVjdCBpbl9hZGRyICopMDsKIH0KZGlm
ZiAtcnVOIGF1Yml0NGdsc3JjL2xpYi9saWJ1aS91aV94bWwvdWlsaWIvY29tbXMuYyBhdWJp
dDRnbHNyYy11cGRhdGVkL2xpYi9saWJ1aS91aV94bWwvdWlsaWIvY29tbXMuYwotLS0gYXVi
aXQ0Z2xzcmMvbGliL2xpYnVpL3VpX3htbC91aWxpYi9jb21tcy5jCTIwMjAtMDUtMjEgMjM6
MTg6MjQuMDAwMDAwMDAwICswMzAwCisrKyBhdWJpdDRnbHNyYy11cGRhdGVkL2xpYi9saWJ1
aS91aV94bWwvdWlsaWIvY29tbXMuYwkyMDIzLTA3LTI3IDE4OjQwOjI5Ljk2MDY3NDc5MiAr
MDMwMApAQCAtOTcsOCArOTcsMTIgQEAKIHN0YXRpYyBzdHJ1Y3QgaW5fYWRkciAqCiBhdG9h
ZGRyIChjaGFyICphZGRyZXNzKQogewotICBzdHJ1Y3QgaG9zdGVudCAqaG9zdDsKICAgc3Rh
dGljIHN0cnVjdCBpbl9hZGRyIHNhZGRyOworICBzdHJ1Y3QgYWRkcmluZm8gaGludHMsICpy
ZXMsICpwOworCisgIG1lbXNldCgmaGludHMsIDAsIHNpemVvZihoaW50cykpOworICBoaW50
cy5haV9mYW1pbHkgPSBBRl9JTkVUOworICBpbnQgc3RhdHVzOwogCiAgIC8vIEZpcnN0IHRy
eSBpdCBhcyBhYWEuYmJiLmNjYy5kZGQuCiAgIHNhZGRyLnNfYWRkciA9IGluZXRfYWRkciAo
YWRkcmVzcyk7CkBAIC0xMDYsMTAgKzExMCwxMiBAQAogICAgIHsKICAgICAgIHJldHVybiAm
c2FkZHI7CiAgICAgfQotICBob3N0ID0gZ2V0aG9zdGJ5bmFtZSAoYWRkcmVzcyk7Ci0gIGlm
IChob3N0ICE9IE5VTEwpCisgIHN0YXR1cyA9IGdldGFkZHJpbmZvKGFkZHJlc3MsIE5VTEws
ICZoaW50cywgJnJlcyk7CisgIGlmIChzdGF0dXMgPT0gMCkKICAgICB7Ci0gICAgICByZXR1
cm4gKHN0cnVjdCBpbl9hZGRyICopICpob3N0LT5oX2FkZHJfbGlzdDsKKyAgICAgIHN0cnVj
dCBpbl9hZGRyICppcHYgPSAoc3RydWN0IGluX2FkZHIgKilyZXMtPmFpX2FkZHI7CisgICAg
ICBzdHJ1Y3QgaW5fYWRkciAqYWRkciA9ICYoaXB2LT5zaW5fYWRkcik7CisgICAgICByZXR1
cm4gYWRkcjsKICAgICB9CiAgIHJldHVybiAoc3RydWN0IGluX2FkZHIgKikwOwogfQo=

--------------fdWc8qGvvyimcOMzKIvV4rBa
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--------------fdWc8qGvvyimcOMzKIvV4rBa
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Aubit4gl-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/aubit4gl-discuss

--------------fdWc8qGvvyimcOMzKIvV4rBa--