Re: Replace gethostbyname with getaddrinfo

This is a multi-part message in MIME format.
--------------233W02O2oZV6qho2aXDzBMeW
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Sorry, should be s_addr

Should I create a separate branch in subversion?

On 7/30/23 14:06, Mike Aubury wrote:
> Fails to compile for me : 
> 
> gmake[4]: Entering directory
> '/home/aubit4gl/svn/aubit4gl-aubit4gl_code/aubit4glsrc/trunk/lib/libui/ui_xml/uilib'
> gcc  -Wall -Wredundant-decls -Wmissing-declarations -Wmissing-prototypes
> -Wstrict-prototypes -g -g  -fPIC -DPIC -DSRC_TREE -DDEBUG
> -DHAVE_CONFIG_H= -I/home/aubit4gl/aubit4glsrc/incl
> -I/home/aubit4gl/aubit4glsrc  -fPIC -DPIC -I../../../../lib/libui/ui_xml
> -I../../../../lib/libui/ui_xml/uilib
> -I../../../../lib/libui/ui_xml/uilib/aubit4gl -Wall -Ixml   -c -o
> comms.o comms.c
> comms.c: In function 'atoaddr':
> comms.c:117:35: error: 'struct in_addr' has no member named 'sin_addr'
>        struct in_addr *addr = &(ipv->sin_addr);
>                                    ^
> comms.c:101:33: warning: unused variable 'p' [-Wunused-variable]
>    struct addrinfo hints, *res, *p;
> 
> 
> 
> (i'm running a fairly old version of ubuntu)
> 
> On Thu, 27 Jul 2023 at 17:24, Benson Muite <[email protected]
> <mailto:[email protected]>> wrote:
> 
>     On 7/13/23 16:48, Benson Muite wrote:
>     > On 7/13/23 16:37, Mike Aubury wrote:
>     >> If you can do a patch, I'd be happy to apply it - I dont think those
>     >> functions will be called by the vast majority of users.
>     >>
>     > Will send a patch
>     Initial patch is attached based on release 1.6.1
> 
>     It requests ipv4 addresses, though one can later update to using both
>     ipv4 and ipv6 addresses
>     >> If you want - I can give you developer access and you can update
>     >> whatever you want :)
>     >>
>     > Thanks. May need to review my changes though.
>     >> On Thu, 13 Jul 2023 at 14:21, Benson Muite
>     <[email protected] <mailto:[email protected]>
>     >> <mailto:[email protected]
>     <mailto:[email protected]>>> wrote:
>     >>
>     >>     The files:
>     >>     lib/libaubit4gl/gui.c
>     >>     lib/libui/ui_json/uilib/comms.c
>     >>     lib/libui/ui_xml/uilib/comms.c
>     >>     lib/libui/ui_highlevel/remote_client/pipeclient.c
>     >>
>     >>     contain gethostbyname, would it be possible to replace this with
>     >>     getaddrinfo?
>     >>
>     >>     Configure script will also need to be updated accordingly. 
>     Can send a
>     >>     patch with a possible implementation if it would be considered.
>     >>
>     >>
>     _______________________________________________
>     Aubit4gl-discuss mailing list
>     [email protected]
>     <mailto:[email protected]>
>     https://lists.sourceforge.net/lists/listinfo/aubit4gl-discuss
>     <https://lists.sourceforge.net/lists/listinfo/aubit4gl-discuss>
> 

--------------233W02O2oZV6qho2aXDzBMeW
Content-Type: text/x-patch; charset=UTF-8; name="getaddrinfo.patch"
Content-Disposition: attachment; filename="getaddrinfo.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtcnVOIGF1Yml0NGdsLTEuNi4xLnAxL2NvbmZpZ3VyZS5pbiBhdWJpdDRnbC0xLjYu
MS5wMS11cGRhdGVkL2NvbmZpZ3VyZS5pbgotLS0gYXViaXQ0Z2wtMS42LjEucDEvY29uZmln
dXJlLmluCTIwMjItMTItMjQgMDM6NTk6NTguMDAwMDAwMDAwICswMzAwCisrKyBhdWJpdDRn
bC0xLjYuMS5wMS11cGRhdGVkL2NvbmZpZ3VyZS5pbgkyMDIzLTA3LTI4IDEzOjIxOjEyLjky
MDIwNjYzNiArMDMwMApAQCAtOTY1OSw3ICs5NjU5LDcgQEAKIAlBQ19GVU5DX01FTUNNUAog
CUFDX1RZUEVfU0lHTkFMCiAJQUNfRlVOQ19WUFJJTlRGCi0JQUNfQ0hFQ0tfRlVOQ1MoW2Zs
b29yIGdldGhvc3RieW5hbWUgaW5ldF9udG9hIG1lbXNldCBwb3cgcHV0ZW52IHJlX2NvbXAg
cmVnY29tcCBzZXRsb2NhbGUgc3RyY2FzZWNtcCBzdHJjaHIgc3RyZHVwIHN0cm5jYXNlY21w
IHN0cnJjaHIgc3Ryc3RyIHN0cnRvbCBpbmRleCByaW5kZXggcG9wZW4gc25wcmludGYgdnNu
cHJpbnRmIHNpZ2FjdGlvbiBnZXR0aW1lb2ZkYXkgdHJ1bmMgc2xlZXAgXSkKKwlBQ19DSEVD
S19GVU5DUyhbZmxvb3IgZ2V0YWRkcmluZm8gaW5ldF9udG9hIG1lbXNldCBwb3cgcHV0ZW52
IHJlX2NvbXAgcmVnY29tcCBzZXRsb2NhbGUgc3RyY2FzZWNtcCBzdHJjaHIgc3RyZHVwIHN0
cm5jYXNlY21wIHN0cnJjaHIgc3Ryc3RyIHN0cnRvbCBpbmRleCByaW5kZXggcG9wZW4gc25w
cmludGYgdnNucHJpbnRmIHNpZ2FjdGlvbiBnZXR0aW1lb2ZkYXkgdHJ1bmMgc2xlZXAgXSkK
IAogCSNzZWxlY3QoKSBhbmQgaW5kZXgoKSBhcmUgdXNlZCBpbiBKYWJiZXIgCiAJI3RoZXJl
IGlzIGFwcHJlbnRseSBhbiBpbmRleCgpIGZ1bmMgc29tZXdoZXJlIGluIGxpYmF1Yml0NGds
IG9yIGluIHNvbWUgbGliCmRpZmYgLXJ1TiBhdWJpdDRnbC0xLjYuMS5wMS9saWIvbGliYXVi
aXQ0Z2wvZ3VpLmMgYXViaXQ0Z2wtMS42LjEucDEtdXBkYXRlZC9saWIvbGliYXViaXQ0Z2wv
Z3VpLmMKLS0tIGF1Yml0NGdsLTEuNi4xLnAxL2xpYi9saWJhdWJpdDRnbC9ndWkuYwkyMDEw
LTAyLTE2IDE2OjE4OjI3LjAwMDAwMDAwMCArMDMwMAorKysgYXViaXQ0Z2wtMS42LjEucDEt
dXBkYXRlZC9saWIvbGliYXViaXQ0Z2wvZ3VpLmMJMjAyMy0wNy0yOCAxNjowNTo0NS45Mzk3
OTU5OTUgKzAzMDAKQEAgLTE2Nyw4ICsxNjcsMTIgQEAKIHN0YXRpYyBzdHJ1Y3QgaW5fYWRk
ciAqCiBhdG9hZGRyIChjaGFyICphZGRyZXNzKQogewotICBzdHJ1Y3QgaG9zdGVudCAqaG9z
dDsKICAgc3RhdGljIHN0cnVjdCBpbl9hZGRyIHNhZGRyOworICBzdHJ1Y3QgYWRkcmluZm8g
aGludHMsICpyZXMsICpwOworIAorICBtZW1zZXQoJmhpbnRzLCAwLCBzaXplb2YoaGludHMp
KTsKKyAgaGludHMuYWlfZmFtaWx5ID0gQUZfSU5FVDsKKyAgaW50IHN0YXR1czsKIAogICAv
LyBGaXJzdCB0cnkgaXQgYXMgYWFhLmJiYi5jY2MuZGRkLgogICBzYWRkci5zX2FkZHIgPSBp
bmV0X2FkZHIgKGFkZHJlc3MpOwpAQCAtMTc2LDExICsxODAsMTQgQEAKICAgICB7CiAgICAg
ICByZXR1cm4gJnNhZGRyOwogICAgIH0KLSAgaG9zdCA9IGdldGhvc3RieW5hbWUgKGFkZHJl
c3MpOwotICBpZiAoaG9zdCAhPSBOVUxMKQorICBzdGF0dXMgPSBnZXRhZGRyaW5mbyhhZGRy
ZXNzLCBOVUxMLCAmaGludHMsICZyZXMpOworICBpZiAoc3RhdHVzID09IDApCiAgICAgewot
ICAgICAgcmV0dXJuIChzdHJ1Y3QgaW5fYWRkciAqKSAqaG9zdC0+aF9hZGRyX2xpc3Q7Cisg
ICAgICBzdHJ1Y3QgaW5fYWRkciAqaXB2ID0gKHN0cnVjdCBpbl9hZGRyICopcmVzLT5haV9h
ZGRyOworICAgICAgc3RydWN0IGluX2FkZHIgKmFkZHIgPSAmKGlwdi0+c19hZGRyKTsKKyAg
ICAgIHJldHVybiAmYWRkcjsKICAgICB9CisKICAgcmV0dXJuIChzdHJ1Y3QgaW5fYWRkciAq
KTA7CiB9CiAqLwpkaWZmIC1ydU4gYXViaXQ0Z2wtMS42LjEucDEvbGliL2xpYnVpL3VpX2hp
Z2hsZXZlbC9yZW1vdGVfY2xpZW50L3BpcGVjbGllbnQuYyBhdWJpdDRnbC0xLjYuMS5wMS11
cGRhdGVkL2xpYi9saWJ1aS91aV9oaWdobGV2ZWwvcmVtb3RlX2NsaWVudC9waXBlY2xpZW50
LmMKLS0tIGF1Yml0NGdsLTEuNi4xLnAxL2xpYi9saWJ1aS91aV9oaWdobGV2ZWwvcmVtb3Rl
X2NsaWVudC9waXBlY2xpZW50LmMJMjAwNy0wOS0xNCAxNzo0NDoxMC4wMDAwMDAwMDAgKzAz
MDAKKysrIGF1Yml0NGdsLTEuNi4xLnAxLXVwZGF0ZWQvbGliL2xpYnVpL3VpX2hpZ2hsZXZl
bC9yZW1vdGVfY2xpZW50L3BpcGVjbGllbnQuYwkyMDIzLTA3LTI4IDEzOjM0OjQ0LjUyNzE1
OTgyMiArMDMwMApAQCAtNjUsOCArNjUsMTIgQEAKIHN0YXRpYyBzdHJ1Y3QgaW5fYWRkciAq
CiBpbnRlcm5hbF9hdG9hZGRyIChjaGFyICphZGRyZXNzKQogewotICBzdHJ1Y3QgaG9zdGVu
dCAqaG9zdDsKICAgc3RhdGljIHN0cnVjdCBpbl9hZGRyIHNhZGRyOworICBzdHJ1Y3QgYWRk
cmluZm8gaGludHMsICpyZXMsICpwOworIAorICBtZW1zZXQoJmhpbnRzLCAwLCBzaXplb2Yo
aGludHMpKTsKKyAgaGludHMuYWlfZmFtaWx5ID0gQUZfSU5FVDsKKyAgaW50IHN0YXR1czsK
IAogICAvLyBGaXJzdCB0cnkgaXQgYXMgYWFhLmJiYi5jY2MuZGRkLgogICBzYWRkci5zX2Fk
ZHIgPSBpbmV0X2FkZHIgKGFkZHJlc3MpOwpAQCAtNzQsMTEgKzc4LDE0IEBACiAgICAgewog
ICAgICAgcmV0dXJuICZzYWRkcjsKICAgICB9Ci0gIGhvc3QgPSBnZXRob3N0YnluYW1lIChh
ZGRyZXNzKTsKLSAgaWYgKGhvc3QgIT0gTlVMTCkKKyAgICBzdGF0dXMgPSBnZXRhZGRyaW5m
byhhZGRyZXNzLCBOVUxMLCAmaGludHMsICZyZXMpOworICBpZiAoc3RhdHVzID09IDApCiAg
ICAgewotICAgICAgcmV0dXJuIChzdHJ1Y3QgaW5fYWRkciAqKSAqaG9zdC0+aF9hZGRyX2xp
c3Q7CisgICAgICBzdHJ1Y3QgaW5fYWRkciAqaXB2ID0gKHN0cnVjdCBpbl9hZGRyICopcmVz
LT5haV9hZGRyOworICAgICAgc3RydWN0IGluX2FkZHIgKmFkZHIgPSAmKGlwdi0+c19hZGRy
KTsKKyAgICAgIHJldHVybiAmYWRkcjsKICAgICB9CisKICAgcmV0dXJuIChzdHJ1Y3QgaW5f
YWRkciAqKSAwOwogfQogCmRpZmYgLXJ1TiBhdWJpdDRnbC0xLjYuMS5wMS9saWIvbGlidWkv
dWlfanNvbi91aWxpYi9jb21tcy5jIGF1Yml0NGdsLTEuNi4xLnAxLXVwZGF0ZWQvbGliL2xp
YnVpL3VpX2pzb24vdWlsaWIvY29tbXMuYwotLS0gYXViaXQ0Z2wtMS42LjEucDEvbGliL2xp
YnVpL3VpX2pzb24vdWlsaWIvY29tbXMuYwkyMDEzLTEwLTEwIDEwOjQ2OjAxLjAwMDAwMDAw
MCArMDMwMAorKysgYXViaXQ0Z2wtMS42LjEucDEtdXBkYXRlZC9saWIvbGlidWkvdWlfanNv
bi91aWxpYi9jb21tcy5jCTIwMjMtMDctMjggMTY6MDU6MzkuNDY4ODE5NzUyICswMzAwCkBA
IC05Nyw4ICs5NywxMiBAQAogc3RhdGljIHN0cnVjdCBpbl9hZGRyICoKIGF0b2FkZHIgKGNo
YXIgKmFkZHJlc3MpCiB7Ci0gIHN0cnVjdCBob3N0ZW50ICpob3N0OwogICBzdGF0aWMgc3Ry
dWN0IGluX2FkZHIgc2FkZHI7CisgIHN0cnVjdCBhZGRyaW5mbyBoaW50cywgKnJlcywgKnA7
CisgCisgIG1lbXNldCgmaGludHMsIDAsIHNpemVvZihoaW50cykpOworICBoaW50cy5haV9m
YW1pbHkgPSBBRl9JTkVUOworICBpbnQgc3RhdHVzOwogCiAgIC8vIEZpcnN0IHRyeSBpdCBh
cyBhYWEuYmJiLmNjYy5kZGQuCiAgIHNhZGRyLnNfYWRkciA9IGluZXRfYWRkciAoYWRkcmVz
cyk7CkBAIC0xMDYsMTEgKzExMCwxNCBAQAogICAgIHsKICAgICAgIHJldHVybiAmc2FkZHI7
CiAgICAgfQotICBob3N0ID0gZ2V0aG9zdGJ5bmFtZSAoYWRkcmVzcyk7Ci0gIGlmIChob3N0
ICE9IE5VTEwpCi0gICAgewotICAgICAgcmV0dXJuIChzdHJ1Y3QgaW5fYWRkciAqKSAqaG9z
dC0+aF9hZGRyX2xpc3Q7Ci0gICAgfQorICBzdGF0dXMgPSBnZXRhZGRyaW5mbyhhZGRyZXNz
LCBOVUxMLCAmaGludHMsICZyZXMpOworICBpZiAoc3RhdHVzID09IDApCisgICAgIHsKKyAg
ICAgIHN0cnVjdCBpbl9hZGRyICppcHYgPSAoc3RydWN0IGluX2FkZHIgKilyZXMtPmFpX2Fk
ZHI7CisgICAgICBzdHJ1Y3QgaW5fYWRkciAqYWRkciA9ICYoaXB2LT5zX2FkZHIpOworICAg
ICAgcmV0dXJuICZhZGRyOworICAgICB9CisKICAgcmV0dXJuIChzdHJ1Y3QgaW5fYWRkciAq
KTA7CiB9CiAKZGlmZiAtcnVOIGF1Yml0NGdsLTEuNi4xLnAxL2xpYi9saWJ1aS91aV94bWwv
dWlsaWIvY29tbXMuYyBhdWJpdDRnbC0xLjYuMS5wMS11cGRhdGVkL2xpYi9saWJ1aS91aV94
bWwvdWlsaWIvY29tbXMuYwotLS0gYXViaXQ0Z2wtMS42LjEucDEvbGliL2xpYnVpL3VpX3ht
bC91aWxpYi9jb21tcy5jCTIwMTktMTAtMDEgMjE6MDI6MzUuMDAwMDAwMDAwICswMzAwCisr
KyBhdWJpdDRnbC0xLjYuMS5wMS11cGRhdGVkL2xpYi9saWJ1aS91aV94bWwvdWlsaWIvY29t
bXMuYwkyMDIzLTA3LTI4IDE2OjA1OjE3LjU3OTkwMDExNiArMDMwMApAQCAtOTcsOCArOTcs
MTIgQEAKIHN0YXRpYyBzdHJ1Y3QgaW5fYWRkciAqCiBhdG9hZGRyIChjaGFyICphZGRyZXNz
KQogewotICBzdHJ1Y3QgaG9zdGVudCAqaG9zdDsKICAgc3RhdGljIHN0cnVjdCBpbl9hZGRy
IHNhZGRyOworICBzdHJ1Y3QgYWRkcmluZm8gaGludHMsICpyZXMsICpwOworIAorICBtZW1z
ZXQoJmhpbnRzLCAwLCBzaXplb2YoaGludHMpKTsKKyAgaGludHMuYWlfZmFtaWx5ID0gQUZf
SU5FVDsKKyAgaW50IHN0YXR1czsKIAogICAvLyBGaXJzdCB0cnkgaXQgYXMgYWFhLmJiYi5j
Y2MuZGRkLgogICBzYWRkci5zX2FkZHIgPSBpbmV0X2FkZHIgKGFkZHJlc3MpOwpAQCAtMTA2
LDExICsxMTAsMTQgQEAKICAgICB7CiAgICAgICByZXR1cm4gJnNhZGRyOwogICAgIH0KLSAg
aG9zdCA9IGdldGhvc3RieW5hbWUgKGFkZHJlc3MpOwotICBpZiAoaG9zdCAhPSBOVUxMKQor
ICBzdGF0dXMgPSBnZXRhZGRyaW5mbyhhZGRyZXNzLCBOVUxMLCAmaGludHMsICZyZXMpOwor
ICBpZiAoc3RhdHVzID09IDApCiAgICAgewotICAgICAgcmV0dXJuIChzdHJ1Y3QgaW5fYWRk
ciAqKSAqaG9zdC0+aF9hZGRyX2xpc3Q7CisgICAgICBzdHJ1Y3QgaW5fYWRkciAqaXB2ID0g
KHN0cnVjdCBpbl9hZGRyICopcmVzLT5haV9hZGRyOworICAgICAgc3RydWN0IGluX2FkZHIg
KmFkZHIgPSAmKGlwdi0+c19hZGRyKTsKKyAgICAgIHJldHVybiAmYWRkcjsKICAgICB9CisK
ICAgcmV0dXJuIChzdHJ1Y3QgaW5fYWRkciAqKTA7CiB9CiAKZGlmZiAtcnVOIGF1Yml0NGds
LTEuNi4xLnAxL3Rvb2xzL25vX3JwYy9jeWd3aW4vcnBjL2F1dGguaCBhdWJpdDRnbC0xLjYu
MS5wMS11cGRhdGVkL3Rvb2xzL25vX3JwYy9jeWd3aW4vcnBjL2F1dGguaAotLS0gYXViaXQ0
Z2wtMS42LjEucDEvdG9vbHMvbm9fcnBjL2N5Z3dpbi9ycGMvYXV0aC5oCTIwMDMtMDUtMTIg
MTc6MjQ6NDMuMDAwMDAwMDAwICswMzAwCisrKyBhdWJpdDRnbC0xLjYuMS5wMS11cGRhdGVk
L3Rvb2xzL25vX3JwYy9jeWd3aW4vcnBjL2F1dGguaAkyMDIzLTA3LTI4IDE0OjMxOjI3Ljc1
MjQ2MTI2OCArMDMwMApAQCAtNzEsOCArNzEsOCBAQAogewogICBzdHJ1Y3QKICAgewotICAg
IHVfaW50MzIgaGlnaDsKLSAgICB1X2ludDMyIGxvdzsKKyAgICB1X2ludDMyX3QgaGlnaDsK
KyAgICB1X2ludDMyX3QgbG93OwogICB9CiAgIGtleTsKICAgY2hhciBjWzhdOwo=

--------------233W02O2oZV6qho2aXDzBMeW
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--------------233W02O2oZV6qho2aXDzBMeW
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Aubit4gl-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/aubit4gl-discuss

--------------233W02O2oZV6qho2aXDzBMeW--