Re: C syntax errors

Not to mention that it uses global variables (and even extern variables) 
throughout instead of parameters...

Absolutely horrible code.  Definitely not to be used as an example!


On 1/17/2014 5:47 PM, James Rich wrote:
> On Sat, 18 Jan 2014, frank kolmann wrote:
>
>> Presumable it has compiled elsewhere.
>> http://www.c-program-example.com/2012/02/k-r-c-programs-exercise-5-20.html
>
> As already mentioned, this appears to be bad code.  Right away, the double
> slashes aren't valid for start of comment in plain C (but are valid in C++
> nad other languages).  Other bad code jumps out in the dcl(void) function
> with these two statements:
>
> for(ns = 0; gettoken() == '*';)
>    ns++;
>
> This appears to simply increment ns as long as the gettoken() function
> returns character '*'.  If that is really the intent they should have
> written:
>
> for(ns = 0; gettoken() == '*'; ns++);
>
> Nit picking, but indicative of other bad code to follow:
>
> while(ns --> 0)
>
> This code will never compile because there is no such thing as a -->
> operator in plain C.  Maybe they meant => but you would just be guessing.
>
> Start with an example that actually works instead of this useless stuff.
> Don't blame yourself, blame the terrible example.
>
> James Rich
>
> if you want to understand why that is, there are many good books on
> the design of operating systems. please pass them along to redmond
> when you're done reading them :)
>   	- Paul Davis on ardour-dev
>
-- 
This is the Bare Metal Programming IBM i (AS/400 and iSeries) (C400-L) mailing list
To post a message email: C400-L-Zwy7GipZuJhWk0Htik3J/[email protected]
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/c400-l
or email: C400-L-request-Zwy7GipZuJhWk0Htik3J/[email protected]
Before posting, please take a moment to review the archives
at http://archive.midrange.com/c400-l.