[dylan-lang/testworks] f7883d: Make all do-check-* functions have same result typ...

GitHub <[email protected]> Wed, 17 Feb 2016 00:30:28 -0800
Newsgroups gmane.comp.lang.dylan.gwydion.cvs
Message-ID <56c42fa43da2e_35723fb8413bf2c01238e3@hookshot-fe4-cp1-prd.iad.github.net.mail>
----==_mimepart_56c42fa43d62c_35723fb8413bf2c01237f9
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

  Branch: refs/heads/cleanup-do-check-functions
  Home:   https://github.com/dylan-lang/testworks
  Commit: f7883dcb724465725007e6fa1d5b3f6bf2c63f34
      https://github.com/dylan-lang/testworks/commit/f7883dcb724465725007e6fa1d5b3f6bf2c63f34
  Author: Bruce Mitchener <[email protected]>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M assertions.dylan
    M tests/testworks-test-suite.dylan

  Log Message:
  -----------
  Make all do-check-* functions have same result type.

One of the do-check-* functions was returning the <result> object
while the others were all just returning the <result-status> object.
Making them all return the same type of result will make it easier
to combine the bulk of the logic into a single helper method or
macro. It also makes it easier to extend the testing in the future
to cover the reasons that are generated for test failures.

* assertions.dylan
  (do-check-instance?): Update return values.
  (do-check-true): Likewise.
  (do-check-false): Likewise.
  (do-check-condition): Likewise.

* tests/testworks-test-suite.dylan
  (test testworks-check-true-test,
   test testworks-assert-true-test,
   test testworks-check-false-test,
   test testworks-assert-false-test,
   test testworks-assert-equal-test,
   test testworks-assert-not-equal-test,
   test testworks-check-instance?-test,
   test testworks-assert-instance?-test,
   test testworks-not-assert-instance?-test,
   test testworks-check-condition-test,
   test testworks-assert-signals-test,
   test testworks-check-no-errors-test,
   test testworks-assert-no-errors-test): Update for new return values
    and to get the actual result status from the result object.


  Commit: e46dcb4ad256003f413fbcb901a1bf384e9f6eed
      https://github.com/dylan-lang/testworks/commit/e46dcb4ad256003f413fbcb901a1bf384e9f6eed
  Author: Bruce Mitchener <[email protected]>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M assertions.dylan

  Log Message:
  -----------
  Update assert-instance? messages.

The other checks use the same terminology as each other, but
the `do-check-instance?` was still using the old terminology.

* assertions.dylan
  (do-check-instance?): Update message text.


Compare: https://github.com/dylan-lang/testworks/compare/f7883dcb7244^...e46dcb4ad256
----==_mimepart_56c42fa43d62c_35723fb8413bf2c01237f9
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
chatter mailing list
[email protected]
https://lists.opendylan.org/mailman/listinfo/chatter
----==_mimepart_56c42fa43d62c_35723fb8413bf2c01237f9--