Re: Please review patch: Making ScriptMaker & friends thread-safe
Kevin Reid <[email protected]>
| Newsgroups | gmane.comp.lang.e.general |
|---|---|
| Message-ID | <[email protected]> |
[Quote ordering edited] On Mar 6, 2010, at 7:02, Mark Miller wrote: > On Fri, Mar 5, 2010 at 7:58 PM, Kevin Reid <[email protected]> wrote: >> There are a number of obvious thread-safety bugs in the core E >> message >> dispatch logic. In theory, this patch fixes them. In practice, it >> at least >> seems to not break anything that I've tested. > > I have never used ConcurrentHashMap before. Assuming it does what it > should, the rest of this patch looks good. +1. It has now been committed as r733. For additional context, the choice of techniques for thread-safe caching was made with advice from here (I asked the question): <http://stackoverflow.com/questions/2348492/multi-thread-object-object-cache-map-in-java > -- Kevin Reid <http://switchb.org/kpreid/>