Re: Various E patches
Kevin Reid <[email protected]>
| Newsgroups | gmane.comp.lang.e.general |
|---|---|
| Message-ID | <[email protected]> |
On Apr 13, 2010, at 7:10, Thomas Leonard wrote: > I'll commit the next set of patches on the proposed branch on > Wednesday. > They are: > > http://gitorious.org/~tal-itinnov/repo-roscidus/it-innovation/commits/proposed I haven't had time to review even your previous Wednesday commits. I'll give my comments just on the descriptions: > * Preserve source information about the collection used in a for > expansion If this is just propagation of SourceSpans from one node to another, good. > * Added SQL quasi-parser I am uncomfortable with this; I think we should start using separate libraries (as by your eloader or my e-modules (and we need to discuss the design principles for that)) rather than packing everything for every purpose into the builtin namespace. In particular, SQL isn't a lots-of-applications-use-it-so-it's-useful-to-bundle thing. > * Fix optimisation of simple return statements What was broken? > * Share a single SafeScope within each vat This sounds like the right thing. Where is it stored? > * Removed unnecessary synchronized on LazyEvalSlot Good. > * In "not synchronously callable" error, give the verb E-on-CL generates "not synchronously callable: rec.verb(args...)" for the message. The implementations shouldn't be gratuitously different in this regard. Do you have a rationale for not printing the other components? -- Kevin Reid <http://switchb.org/kpreid/>