Re: E 0.9.3 release?

On Tue, Nov 9, 2010 at 4:01 AM, Thomas Leonard <
tal-v5nx5w6akNyLE8xUarVfuPLx9OUvmyODWmv/[email protected]> wrote:

> On Sat, 2010-11-06 at 20:11 -0700, Mark S. Miller wrote:
> > On Sat, Nov 6, 2010 at 10:54 AM, Thomas Leonard <[email protected]>
> > wrote:
> >         The 0.9.2a release currently on the main web-site is rather
> >         buggy. In
> >         particular:
> >
> >         - it often fails to start (fixed in r718)
> >         - it contains a known security flaw (fixed in r728)
> >         - it suffers from various race conditions while running
> >
> >         Any chance of a 0.9.3 release?
> >
> >
> > Yes, that's a good idea. I should be able to get to that in early
> > December.
> >
> >
> > Sorry I haven't been finding the time to review your outstanding
> > changes. Could you maintain a page at wiki.erights.org pointing to
> > outstanding changes, so that as I and others do find time to review
> > these, we can easily find them? Thanks.
>
> Done: http://wiki.erights.org/wiki/User:ThomasLeonard
>
> I think the CapTP shutdown patches are the only ones that might be
> useful in the next release.
>
> The Scope/EEnv split may be an API change, so it would make sense to get
> a new stable release out first.
>

Much appreciated!

 1. Fixed infinite-loop processing unknown updoc directives
http://gitorious.org/~tal-itinnov/repo-roscidus/it-innovation/commit/c9f858cd8b2424cd5fa8f789850ebe5044b91582

Looks good, yes.

2. Removed UserThread that was created per ListenThread
http://gitorious.org/~tal-itinnov/repo-roscidus/it-innovation/commit/f5f366d279be6343a92d3eaddd43a4d951f12bc6
(unless someone can explain what this was for)

Assuming I understand the outcome of the conversation between you and Bill
-- that this is no longer needed -- then yes, looks good.

3. Allow result of orderlyShutdown to resolve
http://gitorious.org/~tal-itinnov/repo-roscidus/it-innovation/commit/3f5cb2254efa258aa9724697dab8e87b9890cadf
The result is now a promise in the sending vat, which is resolved by
the VatRedirector. Before, it returned a promise in the vat being shutdown,
which ignored __whenMoreResolved messages.
This should also fix thread-safety bugs in mergeInto, orderlyShutdown and
morphInto.

I think so, but I'm not ready to approve this yet. Need to spend more time
thinking about it and reminding myself of how all this works internally.

4. NearRef.sendMsg propagates exceptions
http://gitorious.org/~tal-itinnov/repo-roscidus/it-innovation/commit/212b024dd8abf19f074df95d818f4a0b593ea829

Please rephrase "Throwing away any problem that is returned here." as
"Ignoring any ...". The term "throwing away", when applied to an exception,
might be confused with throwing the exception. With that changed, looks
good.

5. Added static Runner.whenDead() method to register a deadManSwitch
http://gitorious.org/~tal-itinnov/repo-roscidus/it-innovation/commit/e185c8a1c8fed9344c521c215ec97c9cf701ff98
(not sure whether __reactToLostClient is the right method to call here)

I didn't understand the purpose of this until looking at the next CL.

The synchronous call needs to be wrapped in a try/catch that catches, logs,
and otherwise ignores error thrown by the call.


6. Shut down VatTP automatically when its vat is shut down
http://gitorious.org/~tal-itinnov/repo-roscidus/it-innovation/commit/940fe263450a6bb9c0a34674e23a94f2337749b3

I'll have to get back to this another day.



7. Added "?? shutdown vat @vat" updoc directive
http://gitorious.org/~tal-itinnov/repo-roscidus/it-innovation/commit/7d4f1c55705bef7abafe05fbcb0e688263be2ecd

Postponed as well.


Thanks again for doing all this!!!

-- 
    Cheers,
    --MarkM

_______________________________________________
e-lang mailing list
[email protected]
http://www.eros-os.org/mailman/listinfo/e-lang