Re: Patches for review, mostly on ProcessSugar

LGTM. All four are clearly good and were quite simple to review. Thanks.



On Mon, May 16, 2011 at 6:57 AM, Kevin Reid <kpreid-M/[email protected]> wrote:

> While working on an E project I wrote these changes to E-on-Java. They are
> simple and I am reasonably confident in their correctness, but I would
> appreciate a review, especially of #2 and #4 which are semantic changes.
>
> The patches were generated by git format-patch; any suggestions on better
> ways to publish a bunch of commits for review are welcome. (I have moved my
> workflow to using git-svn instead of svn, as does Thomas Leonard.)
>
> #1 fixes a typo bug: Sugar method Process#attachStderr actually attaches
> stdout. It also notes that these operations as defined leak vats.
>
> #2 adds an operation Process#terminates/0; it is like resultsVow/0 in that
> it returns a promise for when the process terminates, but it does not claim
> stdout or stderr.
>
> #3 fixes misspellings of "opening" and "opener" with two "n"s.
>
> #4 makes CharPipeAdapter flush its Writer (and also copy in bulk); without
> this, output may be indefinitely delayed or lost if nothing other than the
> CharPipeAdapter is working with the Writer and the Writer buffers
> indefinitely.
>
>
>
>
> --
> Kevin Reid                                  <http://switchb.org/kpreid/>
>
>
> _______________________________________________
> e-lang mailing list
> [email protected]
> http://www.eros-os.org/mailman/listinfo/e-lang
>
>


-- 
    Cheers,
    --MarkM

_______________________________________________
e-lang mailing list
[email protected]
http://www.eros-os.org/mailman/listinfo/e-lang