Re: Some minor patches

On Aug 24, 2011, at 10:17, Thomas Leonard wrote:

> Some minor fixes I've been using for a while:
> 
> 
> http://gitorious.org/~tal-itinnov/repo-roscidus/it-innovation/commit/e14b3b40363499712b93680c09d0a730e6b48271
> Give a shorter stack-trace from ELoader if the source file is missing

Is this really worth the additional complexity of the code?

> 
> http://gitorious.org/~tal-itinnov/repo-roscidus/it-innovation/commit/e1882154ea24f349187422305aaf99dea0c4825f
> Added ReadOnlyFile.getCryptoHash()
> This allows passing read-only files to updoc.

Good. This should exist.

Perhaps FileSugar should rethrow NoSuchAlgorithmException as runtime; we aren't expecting that failure. (On the other hand, E doesn't care.)

> http://gitorious.org/~tal-itinnov/repo-roscidus/it-innovation/commit/c41603af25758f2d9d0f33474211c7df5a89abbc
> Clearer error message when a return value fails its guard
> The message is now prefixed by "Bad return value: "

OK. This feels a little unclean, but it's probably not worth thinking about until we have a general plan for Exceptions In E.

-- 
Kevin Reid                                  <http://switchb.org/kpreid/>