Re: Patch for review: show updoc errors immediately

On Sep 26, 2011, at 6:16, Thomas Leonard wrote:

> On 2011-09-21 14:37, Thomas Leonard wrote:
>> One problem I frequently hit with updoc is that it doesn't report errors
>> until the script finishes. But, often, the error prevents the script
>> from finishing. Then you have to bisect the script manually until you
>> see the error.
> [...]
> 
>> Patch:
>> 
>> http://gitorious.org/~tal-itinnov/repo-roscidus/it-innovation/commit/dca612f2a472451881c00ea02e290a398a92b22e
> 
> Any objections to me committing this today?

Sorry, I was waiting on having time to review the existing architecture of makeScriptPlayer and didn't get around to it. I do agree that reporting errors immediately is important for the reason you gave.

Your change looks good overall, except that there should be @param docs for the 'out' parameters you added. Please add those before committing.


Also, another nice thing to have would be to add an option to additionally print the individual steps as they are executing (so that finding a hung/lost-signal test is not a matter of counting dots). Or, since the evaluation occurs in a separate vat from the updoc replay (if I recall correctly), have a timeout after which the step is printed and reported as hung.

-- 
Kevin Reid                                  <http://switchb.org/kpreid/>