Re: Patch for XML pretty printer

Eric Bezault <[email protected]> Thu, 03 Sep 2009 19:33:11 +0200
Newsgroups gmane.comp.lang.eiffel.gobo.devel
Message-ID <[email protected]>
Hi Jann,

Jann Röder wrote:
> I wrote a patch for the XML pretty printer to make it use the short form 
> for tags that don't have content or children, i.e. <tag/> instead of 
> <tag></tag> .
> See attachment.
> 
> I also noticed, that the pretty printer does not output the XML 
> descriptor (this: <?xml version="1.0" ?>). I'm not sure what's the best 
> way to fix this. Simply adding code in the on_xml_descriptor feature 
> doesn't work because it is never called, or I don't know what to do to 
> have it called.
> 
> Anyway in the meantime I'd be glad about some feedback regarding my patch.

It may take a few days before your patch makes it way in the
repository because I'm currently converting the repository to
Git.

I'll let XML experts give feedback on your patch if they have something
to say. But in the meantime, can you please add header comments to the
features `last_call_was_start_tag_finish' and `close_tag_buffered'?
Thanks.

-- 
Eric Bezault
mailto:[email protected]
http://www.gobosoft.com

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july