Re: [PATCH] Prefer details in cdv_ets_cb:init_gen_page/2

Dan Gudmundsson <[email protected]> Mon, 12 Oct 2015 13:10:45 +0000
Newsgroups gmane.comp.lang.erlang.bugs
Message-ID <CANX4uuNx76jc2GqSydRacAakYaac0t_hwp30GpaiH6GtLBFe4Q@mail.gmail.com>
I think this patch is better..

diff --git a/lib/observer/src/crashdump_viewer.erl
b/lib/observer/src/crashdump_viewer.erl
index f2ce51b..b66b4d5 100644
--- a/lib/observer/src/crashdump_viewer.erl
+++ b/lib/observer/src/crashdump_viewer.erl
@@ -1572,7 +1572,7 @@ get_etsinfo(Fd,EtsTable = #ets_table{details=Ds},WS)
->
            get_etsinfo(Fd,EtsTable#ets_table{details=Ds#{fixed=>Val}},WS);
        "Type" ->
            Val = val(Fd),
-
get_etsinfo(Fd,EtsTable#ets_table{details=Ds#{data_type=>Val}},WS);
+           get_etsinfo(Fd,EtsTable#ets_table{data_type=Val},WS);
        "Protection" ->
            Val = val(Fd),

get_etsinfo(Fd,EtsTable#ets_table{details=Ds#{protection=>Val}},WS);



On Fri, Oct 9, 2015 at 3:59 AM Leo Liu <[email protected]> wrote:

> Hi,
>
> When viewing the details page of an ETS table in crashdump_viewer, it
> always shows the `data structure' as `hash'. Could someone see if this
> is an oversight and the following patch is intended? Thanks.
>
> Leo
>
> _______________________________________________
> erlang-bugs mailing list
> [email protected]
> http://erlang.org/mailman/listinfo/erlang-bugs
>

_______________________________________________
erlang-bugs mailing list
[email protected]
http://erlang.org/mailman/listinfo/erlang-bugs