Re: Add crypto:pbkdf2_hmac/5 BIF to the crypto module

Just saying, I already implemented NIFs for this a long time ago, obviously outperforming Basho’s lib by dozens of times, but also even outperforming OpenSSL’s implementation. https://github.com/esl/fast_pbkdf2/ <https://github.com/esl/fast_pbkdf2/> Just some free self-promotion there I guess, but there’s benefit to have it on OTP itself I suppose.

> On 18 Nov 2021, at 16:58, Bryan Frimin <[email protected]> wrote:
> 
> Hello everyone,
> 
> I propose to add the pbkdf2_hmac/2 function to the crypto module.
> 
> PBKD2 with HMAC is used by a lot of applications and libraries in
> Erlang, currently, most of it uses the basho one or a fork of the basho
> one.
> 
> As Erlang already binds OpenSSL and because this function is available
> even on the OpenSSL 0.9.8c, I think it can be a great UX improvement to
> have it from the OTP instead of an external library.
> 
> It's why I suggest enriching the crypto module with this function. I've
> already opened a pull request[1].
> 
> I tried as much as possible to follow the contribution guide. Don't
> hesitate to tell me if I made a mistake somewhere.
> 
> [1] https://github.com/erlang/otp/pull/5421
> 
> Regards,
> 
> -- 
> Bryan Frimin
> https://www.frimin.fr
> [email protected]


-- 
*
*
*Our
upcoming conferences: *

Code Beam America (virtual): 
<https://www2.codesync.global/code-beam-sf-2021/es> 3-5 November
2021







Erlang Solutions cares about your data and privacy;
please find all 
details about the basis for communicating with you and the way we
process 
your data in our Privacy Policy 
<https://www.erlang-solutions.com/privacy-policy.html>. You can
update your 
email preferences or opt-out from receiving Marketing emails here 
<https://www2.erlang-solutions.com/email-preference?epc_hash=JtO6C7Q2rJwCdZxBx3Ad8jI2D4TJum7XcUWcgfjZ8YY>.